Bug 164510
| Summary: | text-combine-upright should ignore forced line breaks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Koji Ishii <kojii> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, mmaxfield, ntim, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | FromImplementor, InRadar |
| Version: | Safari 10 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 150821 | ||
Koji Ishii
The spec 9.1.2. Layout Rules defines "ignoring ... any forced line breaks".
https://drafts.csswg.org/css-writing-modes-3/#text-combine-layout
STEPS:
1. Open http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/text-combine-upright-break-inside-001a/format/html5/
EXPECTED:
Test should render the same as "Reference Page" tab.
Note that since the test does not have prefix, you will need to add one, or use bookmarklets <http://kojiishi.github.io/tweak-css-tests/> to reproduce.
chrome bug: http://crbug.com/663308
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/29181797>
Tim Nguyen (:ntim)
*** Bug 234761 has been marked as a duplicate of this bug. ***
Tim Nguyen (:ntim)
imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001a.html [ ImageOnlyFailure ]
Ahmad Saleem
(In reply to Tim Nguyen (:ntim) from comment #3)
> imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-
> break-inside-001.html [ ImageOnlyFailure ]
> imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-
> break-inside-001a.html [ ImageOnlyFailure ]
We are passing these tests on STP170.
https://wpt.fyi/results/css/css-writing-modes?label=master&label=experimental&aligned&q=text-combine-upright-break-inside
^ Do we need to do anything else? I think we can mark this as fixed.
Tim Nguyen (:ntim)
Looks like this was fixed by some IFC change.
alan
(In reply to Tim Nguyen (:ntim) from comment #5)
> Looks like this was fixed by some IFC change.
Correct, these have progressed at 257036@main when text-combine content got enabled for IFC (tagging with IFC progression).