Bug 164813

Summary: check-webkit-style: False posive Instance of 'Popen' has no 'kill' member [pylint/E1101] [5]
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164792, 169084    

Carlos Alberto Lopez Perez
Reported 2016-11-15 19:19:14 PST
At https://bugs.webkit.org/show_bug.cgi?id=164792#c2 check-webkit-style complains with: ERROR: Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:85: [LinuxBrowserDriver.close_browsers] Instance of 'Popen' has no 'kill' member [pylint/E1101] [5] Total errors found: 1 in 10 files This is a false positive: Popen.kill() Kills the child. On Posix OSs the function sends SIGKILL to the child. On Windows kill() is an alias for terminate(). New in version 2.6. https://docs.python.org/2/library/subprocess.html#subprocess.Popen Note: I want to believe that we don't support python < 2.6 :)
Attachments
Note You need to log in before you can comment on or make changes to this bug.