Bug 165006

Created attachment 295289 [details] Patch

Comment on attachment 295289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295289&action=review In the ChangeLog it's explained very well the problem, but not so clear, IMO, why this patch solves the issue. I'd add some lines to show that we have now 2 different functions to get the size of the grid, one using the pysical representation and the other one, using the logical one. Other than that, the change looks good. > Source/WebCore/ChangeLog:13 > + memory allocations are done to create a grid representation it as it is not needed. typo: "representation *it as it*" -> "representation *as it*

Created attachment 295333 [details] Patch

Comment on attachment 295333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295333&action=review > Source/WebCore/rendering/RenderGrid.cpp:2713 > +unsigned RenderGrid::numTracks(GridTrackSizingDirection direction) const As we talked privately, what do you think about figuring out a more descriptive name for this function and the one we already have, gridColumnCount ? The difference between them is not obvious at all.

(In reply to comment #4) > Comment on attachment 295333 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295333&action=review > > > Source/WebCore/rendering/RenderGrid.cpp:2713 > > +unsigned RenderGrid::numTracks(GridTrackSizingDirection direction) const > > As we talked privately, what do you think about figuring out a more > descriptive name for this function and the one we already have, > gridColumnCount ? The difference between them is not obvious at all. Right, I agree the names are not very good, but I'd prefer to change them later after finishing the refactoring if you don't feel strongly about it (I have a lot of dependent patches in my queue, so this kind of changes will force me to do a lot of conflict resolution).

(In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 295333 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=295333&action=review > > > > > Source/WebCore/rendering/RenderGrid.cpp:2713 > > > +unsigned RenderGrid::numTracks(GridTrackSizingDirection direction) const > > > > As we talked privately, what do you think about figuring out a more > > descriptive name for this function and the one we already have, > > gridColumnCount ? The difference between them is not obvious at all. > > Right, I agree the names are not very good, but I'd prefer to change them > later after finishing the refactoring if you don't feel strongly about it (I > have a lot of dependent patches in my queue, so this kind of changes will > force me to do a lot of conflict resolution). Sure, no problem with waiting until the refactoring is completed.

Comment on attachment 295333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295333&action=review LGTM. > Source/WebCore/rendering/RenderGrid.h:195 > unsigned gridColumnCount() const; > unsigned gridRowCount() const; > + unsigned numTracks(GridTrackSizingDirection) const; I'd add a FIXME on these 3 methods to look for better names once the refactoring is done.

Committed r208962: <http://trac.webkit.org/changeset/208962>