Bug 166536

Summary: [GTK][WPE] WebGL2 support
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: aboya, alex, aperez, bugs-noreply, chi187, clopez, commit-queue, lmoura, Synper311, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208188
https://bugs.webkit.org/show_bug.cgi?id=188217
https://bugs.webkit.org/show_bug.cgi?id=229051
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews112 for mac-elcapitan
none
WIP none

Zan Dobersek
Reported 2016-12-28 08:40:08 PST
[GTK] WebGL2 support
Attachments
Patch (12.34 KB, patch)
2016-12-28 08:40 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-elcapitan (1.50 MB, application/zip)
2016-12-28 09:49 PST, Build Bot 		no flags
Details
WIP (13.51 KB, patch)
2017-05-14 23:22 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-12-28 08:40:30 PST
Created attachment 297811 [details] Patch
Zan Dobersek
Comment 2 2016-12-28 08:42:00 PST
Not marked for review since I still have to figure out whether it's possible to keep this thing enabled at compile-time, but disabled at runtime in case the platform doesn't manage more than OpenGLES 2.
WebKit Commit Bot
Comment 3 2016-12-28 08:42:05 PST
Attachment 297811 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 4 2016-12-28 09:48:59 PST
Comment on attachment 297811 [details] Patch Attachment 297811 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2798950 New failing tests: imported/w3c/web-platform-tests/IndexedDB/interfaces.worker.html
Build Bot
Comment 5 2016-12-28 09:49:01 PST
Created attachment 297814 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Carlos Alberto Lopez Perez
Comment 6 2017-03-21 09:05:39 PDT
Skipped the WebGL 2.0 tests in https://trac.webkit.org/r214223
Zan Dobersek
Comment 7 2017-05-14 23:22:20 PDT
Created attachment 310111 [details] WIP
Alicia Boya García
Comment 8 2018-12-05 15:20:03 PST
Marking this bug to this test in GTK expectations: fast/canvas/webgl/hide-some-renderer-info.html --- /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/layout-test-results/fast/canvas/webgl/hide-some-renderer-info-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/layout-test-results/fast/canvas/webgl/hide-some-renderer-info-actual.txt @@ -1,3 +1,3 @@ PASS: Renderer was appropriately hidden for WebGL 1. -PASS: Renderer was appropriately hidden for WebGL 2. +WebGL2: Not available
Lauro Moura
Comment 9 2020-12-06 19:11:03 PST
Adding to "see also" a related WPE bug to that skipped the WebGL2 tests in WPE. Should it be kept separate or tracked together here?
Adrian Perez
Comment 10 2022-06-12 14:00:47 PDT
*** Bug 235626 has been marked as a duplicate of this bug. ***
Alejandro G. Castro
Comment 11 2023-02-01 05:24:19 PST
WebGL2 support for the GTK and WPE ports was added and layout tests activated already in main branch.
Radar WebKit Bug Importer
Comment 12 2023-02-01 05:25:25 PST
<rdar://problem/104912129>
Note You need to log in before you can comment on or make changes to this bug.