Bug 169978

Summary:

Support RTCPeerConnectionState

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, eric.carlson, jonlee

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

169662, 169989

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Patch for landing	none
Patch for landing	none

youenn fablet

Reported 2017-03-22 16:45:34 PDT

https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum

Attachments
Patch (34.76 KB, patch) 2017-03-22 17:08 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.71 MB, application/zip) 2017-03-22 18:26 PDT, Build Bot	no flags	Details
Patch for landing (34.81 KB, patch) 2017-03-22 18:51 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (34.81 KB, patch) 2017-03-22 19:03 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-03-22 17:08:51 PDT

Created attachment 305139 [details] Patch

youenn fablet

Comment 2 2017-03-22 17:10:03 PDT

Added test might not be interoperable. Plan will be to move it to web-platform-tests when possible and fix any interop there.

Jon Lee

Comment 3 2017-03-22 17:35:26 PDT

Comment on attachment 305139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305139&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-78 > - // FIXME 169644: change to RTCSessionDescriptionInit Why is this removed? The signature should be updated even if it's handled by the builtin. > Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-147 > - // FIXME 169644: convert to (MediaStreamTrack or DOMString) Why is this removed?

Build Bot

Comment 4 2017-03-22 18:26:11 PDT

Comment on attachment 305139 [details] Patch Attachment 305139 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3390928 New failing tests: media/video-main-content-autoplay.html

Build Bot

Comment 5 2017-03-22 18:26:13 PDT

Created attachment 305150 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

youenn fablet

Comment 6 2017-03-22 18:46:53 PDT

(In reply to Jon Lee from comment #3) > Comment on attachment 305139 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305139&action=review > > > Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-78 > > - // FIXME 169644: change to RTCSessionDescriptionInit > > Why is this removed? The signature should be updated even if it's handled by > the builtin. I forgot to update it to RTCSessionDescriptionInit, will do at landing time. > > > Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-147 > > - // FIXME 169644: convert to (MediaStreamTrack or DOMString) > > Why is this removed? This is handled through overloading (see the two addTransceiver methods below).

youenn fablet

Comment 7 2017-03-22 18:51:09 PDT

Created attachment 305151 [details] Patch for landing

Jon Lee

Comment 8 2017-03-22 18:51:20 PDT

Comment on attachment 305139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305139&action=review >>> Source/WebCore/Modules/mediastream/RTCPeerConnection.idl:-147 >>> - // FIXME 169644: convert to (MediaStreamTrack or DOMString) >> >> Why is this removed? > > This is handled through overloading (see the two addTransceiver methods below). True, though it would be slightly nicer to match the spec exactly rather than having two overloaded methods.

WebKit Commit Bot

Comment 9 2017-03-22 18:52:10 PDT

Comment on attachment 305151 [details] Patch for landing Rejecting attachment 305151 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 305151, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/3391265

youenn fablet

Comment 10 2017-03-22 19:03:24 PDT

Created attachment 305155 [details] Patch for landing

WebKit Commit Bot

Comment 11 2017-03-22 19:45:01 PDT

Comment on attachment 305155 [details] Patch for landing Clearing flags on attachment: 305155 Committed r214293: <http://trac.webkit.org/changeset/214293>

WebKit Commit Bot

Comment 12 2017-03-22 19:45:06 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.