Bug 170425

Summary:

Web Inspector: RTL: layout issues in debugger dashboard, arrows are on wrong side

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, hi, inspector-bugzilla-changes

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	none
RTL - debug dashboard - before	none
RTL - default dashboard - before	none
RTL - debug dashboard - after	none
LTR - debug dashboard - after	none
For Landing	none

Blaze Burg

Reported 2017-04-03 15:25:30 PDT

Whoopsy.

Attachments
Proposed Fix (8.61 KB, patch) 2017-04-03 15:29 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
RTL - debug dashboard - before (32.81 KB, image/png) 2017-04-03 15:29 PDT, Blaze Burg	no flags	Details
RTL - default dashboard - before (21.65 KB, image/png) 2017-04-03 15:30 PDT, Blaze Burg	no flags	Details
RTL - debug dashboard - after (32.66 KB, image/png) 2017-04-03 15:30 PDT, Blaze Burg	no flags	Details
LTR - debug dashboard - after (32.86 KB, image/png) 2017-04-03 15:30 PDT, Blaze Burg	no flags	Details
For Landing (8.63 KB, patch) 2017-04-04 13:10 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2017-04-03 15:29:09 PDT

Created attachment 306125 [details] Proposed Fix

Blaze Burg

Comment 2 2017-04-03 15:29:59 PDT

Created attachment 306126 [details] RTL - debug dashboard - before

Blaze Burg

Comment 3 2017-04-03 15:30:18 PDT

Created attachment 306127 [details] RTL - default dashboard - before

Blaze Burg

Comment 4 2017-04-03 15:30:37 PDT

Created attachment 306128 [details] RTL - debug dashboard - after

Blaze Burg

Comment 5 2017-04-03 15:30:53 PDT

Created attachment 306129 [details] LTR - debug dashboard - after

Devin Rousso

Comment 6 2017-04-03 15:31:28 PDT

Comment on attachment 306125 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306125&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css:152 > + --dashboard-advance-arrow-end: 0px; I think we are using "offset" to represent positioning values in CSS variable names. --dashboard-advance-arrow-offset-end: 0;

Blaze Burg

Comment 7 2017-04-03 23:33:13 PDT

(In reply to Devin Rousso from comment #6) > Comment on attachment 306125 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306125&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css:152 > > + --dashboard-advance-arrow-end: 0px; > > I think we are using "offset" to represent positioning values in CSS > variable names. > > --dashboard-advance-arrow-offset-end: 0; OK

Blaze Burg

Comment 8 2017-04-04 13:10:07 PDT

Created attachment 306189 [details] For Landing

WebKit Commit Bot

Comment 9 2017-04-04 14:30:07 PDT

The commit-queue encountered the following flaky tests while processing attachment 306189 [details]: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: graouts@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 10 2017-04-04 14:30:33 PDT

Comment on attachment 306189 [details] For Landing Clearing flags on attachment: 306189 Committed r214899: <http://trac.webkit.org/changeset/214899>

WebKit Commit Bot

Comment 11 2017-04-04 14:30:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.