Bug 171222

Created attachment 307974 [details] Patch Still has to enable the relevant layout tests.

Attachment 307974 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:160: CryptoAlgorithmRSA_OAEP::platformEncrypt is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:188: CryptoAlgorithmRSA_OAEP::platformDecrypt is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 308234 [details] Patch

Attachment 308234 [details] did not pass style-queue: ERROR: Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:160: CryptoAlgorithmRSA_OAEP::platformEncrypt is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:188: CryptoAlgorithmRSA_OAEP::platformDecrypt is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 308234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308234&action=review > Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:57 > -void CryptoAlgorithmRSA_OAEP::platformEncrypt(std::unique_ptr<CryptoAlgorithmParameters>&&, Ref<CryptoKey>&&, Vector<uint8_t>&&, VectorCallback&&, ExceptionCallback&&, ScriptExecutionContext&, WorkQueue&) > +static std::optional<const char*> hashAlgorithmName(CryptoAlgorithmIdentifier identifier) > { > - notImplemented(); > + switch (identifier) { > + case CryptoAlgorithmIdentifier::SHA_1: > + return "sha1"; > + case CryptoAlgorithmIdentifier::SHA_224: > + return "sha224"; > + case CryptoAlgorithmIdentifier::SHA_256: > + return "sha256"; > + case CryptoAlgorithmIdentifier::SHA_384: > + return "sha384"; > + case CryptoAlgorithmIdentifier::SHA_512: > + return "sha512"; > + default: > + return std::nullopt; > + } > } This is getting a bit absurd... it needs to move to a shared location. > Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:59 > +static std::optional<Vector<uint8_t>> mpiData(gcry_sexp_t paramSexp) This too... don't you have some utility file for stuff like this? You need one.

Comment on attachment 308234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308234&action=review >> Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:59 >> +static std::optional<Vector<uint8_t>> mpiData(gcry_sexp_t paramSexp) > > This too... don't you have some utility file for stuff like this? You need one. I'll add it after the patches land, that way it's easier to update all the call sites.

Comment on attachment 308234 [details] Patch Looks good to me as well.

Committed r217548: <http://trac.webkit.org/changeset/217548>

<rdar://problem/32479874>