Bug 171342

Summary: Speedometer: Update the Ember.js TodoMVC to a more recent version
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Addy Osmani
Reported 2017-04-26 14:06:49 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), the Ember.js implementation of TodoMVC needs to be updated to a more recent version. This would update it to a rewrite using ember-cli (the now de facto way of creating Ember apps) and also bump the Ember version used.
Attachments
Patch (2.48 MB, patch)
2017-04-26 14:16 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (4.08 MB, patch)
2017-05-11 22:44 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (4.08 MB, patch)
2017-05-11 22:48 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-26 14:16:46 PDT
Created attachment 308283 [details] Patch
Ryosuke Niwa
Comment 2 2017-05-08 23:20:27 PDT
As usual, please add a blink line between Reviewed by and the change log description, and remove these inline comments as they don't add any value since we're simply importing files. We should also probably comment out setItem in resources/todomvc/architecture-examples/emberjs/source/app/services/repo.js. Is todomvc-fdd2c48cf675753de4a79c857343e23f.js used? If so, that also calls localStorage.setItem. We might need to override window.localStorage in prepare function instead if the minimized version calls setItem.
Addy Osmani
Comment 3 2017-05-11 22:44:33 PDT
Created attachment 309870 [details] Patch
Addy Osmani
Comment 4 2017-05-11 22:48:01 PDT
Created attachment 309871 [details] Patch
Addy Osmani
Comment 5 2017-05-11 22:51:42 PDT
I've added an in-memory localStorage shim that doesn't persist any data to the implementation. I've also added a blank line and trimmed down the inline comments per the other patches.
WebKit Commit Bot
Comment 6 2017-05-11 23:34:18 PDT
Comment on attachment 309871 [details] Patch Clearing flags on attachment: 309871 Committed r216735: <http://trac.webkit.org/changeset/216735>
WebKit Commit Bot
Comment 7 2017-05-11 23:34:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.