Bug 171444

Summary: Speedometer: Add a React.js TodoMVC implementation
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa, sainianky835
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch none

Addy Osmani
Reported 2017-04-28 12:51:38 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), this brings an up to date React TodoMVC implementation to the benchmark.
Attachments
Patch (589.96 KB, patch)
2017-04-28 12:56 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (427.14 KB, patch)
2017-05-11 23:46 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-28 12:56:27 PDT
Created attachment 308579 [details] Patch
Addy Osmani
Comment 2 2017-04-28 16:35:36 PDT
Note: we will want to also remove Speedometer/resources/todomvc/labs/architecture-examples/react (old version)
Ryosuke Niwa
Comment 3 2017-05-09 14:26:26 PDT
Comment on attachment 308579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308579&action=review > PerformanceTests/ChangeLog:7 > + Speedometer: add React.js TodoMVC implementation Again, we need a blank line before this. > PerformanceTests/ChangeLog:10 > + (app.Utils.uuid): Also remove these inline comments.
Addy Osmani
Comment 4 2017-05-11 23:46:13 PDT
Created attachment 309875 [details] Patch
Addy Osmani
Comment 5 2017-05-11 23:46:52 PDT
Added a blank line and removed extraneous comments from the changelog.
WebKit Commit Bot
Comment 6 2017-05-12 02:00:50 PDT
Comment on attachment 309875 [details] Patch Clearing flags on attachment: 309875 Committed r216754: <http://trac.webkit.org/changeset/216754>
WebKit Commit Bot
Comment 7 2017-05-12 02:00:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.