Bug 171471

Summary: Speedometer: Update the Flight.js implementation to a more recent library version
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172077
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Addy Osmani
Reported 2017-04-28 18:56:11 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), this brings an up to date Flight TodoMVC implementation to the benchmark.
Attachments
Patch (1.42 MB, patch)
2017-04-28 18:59 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (1.40 MB, patch)
2017-05-11 15:40 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (1.40 MB, patch)
2017-05-11 16:28 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-28 18:59:51 PDT
Created attachment 308648 [details] Patch
Ryosuke Niwa
Comment 2 2017-05-08 21:55:24 PDT
Comment on attachment 308648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308648&action=review > PerformanceTests/ChangeLog:22 Please remove these per-rule comments throughout your change log since they don't add any meaningful value.
Addy Osmani
Comment 3 2017-05-11 15:40:32 PDT
Created attachment 309801 [details] Patch
Addy Osmani
Comment 4 2017-05-11 16:28:50 PDT
Created attachment 309816 [details] Patch
Addy Osmani
Comment 5 2017-05-11 16:29:38 PDT
Removed per-rule comments throughout the changelog. Let me know if I missed anything.
Ryosuke Niwa
Comment 6 2017-05-11 16:30:32 PDT
Nice! Let's start landing these!
WebKit Commit Bot
Comment 7 2017-05-11 17:15:28 PDT
Comment on attachment 309816 [details] Patch Clearing flags on attachment: 309816 Committed r216708: <http://trac.webkit.org/changeset/216708>
WebKit Commit Bot
Comment 8 2017-05-11 17:15:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.