Bug 171864

Summary: [Win] Specify source file type when preprocessing IDL files
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, lforschler, pvollan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 171618    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2017-05-09 10:37:53 PDT
The source file type, https://msdn.microsoft.com/en-us/library/032xwy55.aspx, should be specified to the preprocessor when running IDL generation.
Attachments
Patch (1.21 KB, patch)
2017-05-09 16:27 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-09 16:27:25 PDT
Created attachment 309559 [details] Patch Adds /FP to the list of CODE_GENERATOR_PREPROCESSOR_ARGUMENTS. This is equivalent to the -x cpp used in GCC/Clang.
Alex Christensen
Comment 2 2017-05-09 16:55:29 PDT
I have a bot building with VS2017 now and it's fine without this. What does this improve or fix?
Don Olmstead
Comment 3 2017-05-09 17:01:41 PDT
(In reply to Alex Christensen from comment #2) > I have a bot building with VS2017 now and it's fine without this. What does > this improve or fix? I'm trying to get things building with clang-cl. With cl the flag isn't explicitly needed for it to function. With clang-cl if the flag isn't there then it returns nothing to STDOUT and the build fails.
WebKit Commit Bot
Comment 4 2017-05-10 07:31:33 PDT
Comment on attachment 309559 [details] Patch Clearing flags on attachment: 309559 Committed r216583: <http://trac.webkit.org/changeset/216583>
WebKit Commit Bot
Comment 5 2017-05-10 07:31:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.