Bug 173483

Summary: Port setup_environ_for_server should not set environment variables related with the driver.
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, buildbot, cgarcia, clopez, dbates, glenn, jbedard, lforschler, rniwa, youennf, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 173433    
Attachments:
Description Flags
Patch cgarcia: review+

Carlos Alberto Lopez Perez
Reported 2017-06-16 11:17:19 PDT
On bug 173433 I found that the port setup_environ_for_server() is setting some environment variables (like DISPLAY) that should not be setted there. Its the job of the driver (on _setup_environ_for_test()) setting that variables.
Attachments
Patch (24.88 KB, patch)
2017-06-16 11:41 PDT, Carlos Alberto Lopez Perez 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2017-06-16 11:41:08 PDT
Created attachment 313101 [details] Patch
Carlos Garcia Campos
Comment 2 2017-06-17 00:13:41 PDT
Comment on attachment 313101 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313101&action=review > Tools/Scripts/webkitpy/port/base.py:871 > + # Use the driver _setup_environ_for_test() method for that.. Double . at the end.
Carlos Alberto Lopez Perez
Comment 3 2017-06-19 03:39:32 PDT
Committed r218482: <http://trac.webkit.org/changeset/218482>
Carlos Alberto Lopez Perez
Comment 4 2017-06-19 06:01:28 PDT
Committed r218490: <http://trac.webkit.org/changeset/218490>
Note You need to log in before you can comment on or make changes to this bug.