Bug 173547

Summary: [GCrypt] Drop the AES-CFB support
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, jiewen_tan, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133122    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch
none
Patch none

Zan Dobersek
Reported 2017-06-19 07:00:42 PDT
[GCrypt] Drop the AES-CFB support
Attachments
Patch (26.25 KB, patch)
2017-06-19 07:06 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.02 MB, application/zip)
2017-06-19 08:13 PDT, Build Bot 		no flags
Details
Patch (26.45 KB, patch)
2017-06-19 08:24 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (26.46 KB, patch)
2017-06-19 08:57 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-06-19 07:06:03 PDT
Created attachment 313291 [details] Patch
Build Bot
Comment 2 2017-06-19 08:13:16 PDT
Comment on attachment 313291 [details] Patch Attachment 313291 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3957659 New failing tests: fast/forms/file/intrinsic-min-width-overrides-width.html
Build Bot
Comment 3 2017-06-19 08:13:17 PDT
Created attachment 313297 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Zan Dobersek
Comment 4 2017-06-19 08:24:26 PDT
Created attachment 313301 [details] Patch
Zan Dobersek
Comment 5 2017-06-19 08:57:09 PDT
Created attachment 313304 [details] Patch
Zan Dobersek
Comment 6 2017-06-19 08:57:18 PDT
For what it's worth this hasn't been discussed yet, but given it's code removal it's simple to provide a starting patch. The idea is that the libgcrypt-based implementation would not, at least initially, support algorithms outside of the Web Crypto specification.
Jiewen Tan
Comment 7 2017-06-21 17:45:49 PDT
Comment on attachment 313304 [details] Patch Looks good to me. r=me.
Zan Dobersek
Comment 8 2017-06-23 05:03:13 PDT
Comment on attachment 313304 [details] Patch Clearing flags on attachment: 313304 Committed r218744: <http://trac.webkit.org/changeset/218744>
Zan Dobersek
Comment 9 2017-06-23 05:03:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.