Bug 173630

Summary: [Curl] ResourceHandleManager violate the class responsibility of ResourceHandle
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebCore Misc.Assignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, buildbot, commit-queue, don.olmstead, fujii.hironori, galpeter
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173629    
Bug Blocks: 117300, 173963, 173964    
Attachments:
Description Flags
Refactoring none

Basuke Suzuki
Reported 2017-06-20 17:40:16 PDT
ResourceHandleManager directly manipulates the ResourceHandle contents, but it should be moved into ResourceHandle and ResourceHandleInternal by themselves.
Attachments
Refactoring (69.48 KB, patch)
2017-06-29 14:18 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-06-29 14:18:20 PDT
Created attachment 314164 [details] Refactoring This patch is simply move methods and functions from ResourceHandleManager to ResourceHandle if possible. ResourceHandleManager apparently violent the class policy and it takes care of ResourceHandle too much which prevents to improve its own responsibility, which is managing ResourceHandle well.
WebKit Commit Bot
Comment 2 2017-06-29 14:58:59 PDT
Comment on attachment 314164 [details] Refactoring Clearing flags on attachment: 314164 Committed r218962: <http://trac.webkit.org/changeset/218962>
WebKit Commit Bot
Comment 3 2017-06-29 14:59:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.