Bug 173983

Summary: Web Inspector: Provide a way for creating a new tab but not making it immediately selected
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=173807
Attachments:
Description Flags
Patch
joepeck: review+
Patch none

Devin Rousso
Reported 2017-06-29 12:50:31 PDT
This would be useful for creating background tabs, such as if multiple recordings are captured at once.
Attachments
Patch (14.63 KB, patch)
2017-06-29 13:17 PDT, Devin Rousso 		joepeck: review+
DetailsFormatted DiffDiff
Patch (14.92 KB, patch)
2017-06-29 18:47 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-06-29 13:17:26 PDT
Created attachment 314157 [details] Patch
Matt Baker
Comment 2 2017-06-29 13:51:07 PDT
I think we should discuss this as a team before moving foreard. I'm not convinced having a tab "per recording" for canvases is a good idea.
Devin Rousso
Comment 3 2017-06-29 14:06:36 PDT
(In reply to Matt Baker from comment #2) > I think we should discuss this as a team before moving foreard. I'm not > convinced having a tab "per recording" for canvases is a good idea. This is unrelated to this change. All this change does is allow tabs to be created and not immediately selected. What you described is not made possible by this change.
Matt Baker
Comment 4 2017-06-29 14:23:55 PDT
(In reply to Devin Rousso from comment #3) > (In reply to Matt Baker from comment #2) > > I think we should discuss this as a team before moving foreard. I'm not > > convinced having a tab "per recording" for canvases is a good idea. > > This is unrelated to this change. All this change does is allow tabs to be > created and not immediately selected. What you described is not made > possible by this change. I should have looked more closely. Your initial description made me think it had to do with multiple tabs per recording. If this isn't being used yet, it should probably wait (at least until a bug can be added to "Blocks").
Joseph Pecoraro
Comment 5 2017-06-29 16:51:39 PDT
Comment on attachment 314157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314157&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:-1123 > - if (representedObject instanceof WebInspector.Collection) > - return WebInspector.CollectionContentView; Why is this getting removed?
Joseph Pecoraro
Comment 6 2017-06-29 16:53:11 PDT
Comment on attachment 314157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314157&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:-1123 >> - return WebInspector.CollectionContentView; > > Why is this getting removed? r=me, but this deserves a comment in the ChangeLog. It looks like it is just bad code, but its not in line with the rest of the patch so it deserves a specific comment.
Devin Rousso
Comment 7 2017-06-29 18:47:16 PDT
Created attachment 314204 [details] Patch
WebKit Commit Bot
Comment 8 2017-06-29 19:25:05 PDT
Comment on attachment 314204 [details] Patch Clearing flags on attachment: 314204 Committed r218984: <http://trac.webkit.org/changeset/218984>
WebKit Commit Bot
Comment 9 2017-06-29 19:25:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.