Bug 175070

Summary:

Remove outline bounds rect repainting

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

bfulgham, buildbot, rniwa, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+, buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none

Dave Hyatt

Reported 2017-08-02 08:48:01 PDT

Outline bounds rect repainting is no longer needed, since outline is now part of visual overflow.

Attachments
Patch (159.66 KB, patch) 2017-08-02 08:51 PDT, Dave Hyatt	zalan: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (9.38 MB, application/zip) 2017-08-02 10:44 PDT, Build Bot	no flags	Details
Patch (159.94 KB, patch) 2017-08-02 11:54 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.37 MB, application/zip) 2017-08-02 18:07 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2017-08-02 08:51:15 PDT

Created attachment 316962 [details] Patch

Build Bot

Comment 2 2017-08-02 08:53:23 PDT

Attachment 316962 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayer.h:121: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

alan

Comment 3 2017-08-02 09:36:10 PDT

Comment on attachment 316962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316962&action=review > Source/WebCore/rendering/RenderLayer.h:125 > +struct LayoutRepaintRects > +{ > + LayoutRect m_clippedOverflowRect; > + LayoutRect m_outlineBounds; > +}; > + This looks unrelated. (guess it's from an upcoming patch)

Build Bot

Comment 4 2017-08-02 10:44:11 PDT

Comment on attachment 316962 [details] Patch Attachment 316962 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4240499 New failing tests: compositing/repaint/absolute-painted-into-composited-ancestor.html

Build Bot

Comment 5 2017-08-02 10:44:13 PDT

Created attachment 316971 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Dave Hyatt

Comment 6 2017-08-02 11:54:45 PDT

Created attachment 316980 [details] Patch

Build Bot

Comment 7 2017-08-02 18:07:17 PDT

Comment on attachment 316962 [details] Patch Attachment 316962 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4242978 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.html

Build Bot

Comment 8 2017-08-02 18:07:18 PDT

Created attachment 317051 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Simon Fraser (smfr)

Comment 9 2023-12-12 11:43:51 PST

Fixed via 265761 *** This bug has been marked as a duplicate of bug 265761 ***

Note You need to log in before you can comment on or make changes to this bug.