Bug 175078

Summary: check-webkit-style: deleting lines in a file runs the linter on the whole file
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, buildbot, commit-queue, ddkilzer, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=86142
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2017-08-02 10:44:45 PDT
If we've only removed lines from a file, we will run the linter on the entire file. This is incorrect.
Attachments
Patch (5.11 KB, patch)
2017-08-02 10:58 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2017-08-02 10:50:54 PDT
This was uncovered by <https://bugs.webkit.org/show_bug.cgi?id=86142>.
Jonathan Bedard
Comment 2 2017-08-02 10:58:28 PDT
Created attachment 316974 [details] Patch
David Kilzer (:ddkilzer)
Comment 3 2017-08-02 14:56:39 PDT
Comment on attachment 316974 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-08-02 15:35:47 PDT
Comment on attachment 316974 [details] Patch Clearing flags on attachment: 316974 Committed r220158: <http://trac.webkit.org/changeset/220158>
WebKit Commit Bot
Comment 5 2017-08-02 15:35:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-08-02 15:36:24 PDT
<rdar://problem/33687321>
Note You need to log in before you can comment on or make changes to this bug.