Bug 175084

Summary: [PAL] Move SQL into PAL
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: beidson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 175613    
Bug Blocks: 174942    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2017-08-02 12:22:41 PDT
Move platform/sql into PAL. Currently the contents have dependencies in Module/webdatabase and page/MemoryRelease
Attachments
Patch (9.42 KB, patch)
2017-08-03 13:46 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-08-02 23:24:26 PDT
(In reply to Don Olmstead from comment #0) > Move platform/sql into PAL. > > Currently the contents have dependencies in Module/webdatabase and > page/MemoryRelease SQLiteDatabase.cpp includes MemoryRelease.h, but doesn't do anything with it. So that's easy. I'm not terribly surprised if, at some point, platform/sql got a layering violation towards webdatabase, but it's not immediately obvious what it is just by looking at the code. Perhaps you could actually share details about your discoveries...?
Don Olmstead
Comment 2 2017-08-03 12:32:37 PDT
(In reply to Brady Eidson from comment #1) > (In reply to Don Olmstead from comment #0) > > Move platform/sql into PAL. > > > > Currently the contents have dependencies in Module/webdatabase and > > page/MemoryRelease > > SQLiteDatabase.cpp includes MemoryRelease.h, but doesn't do anything with > it. So that's easy. > > I'm not terribly surprised if, at some point, platform/sql got a layering > violation towards webdatabase, but it's not immediately obvious what it is > just by looking at the code. > > Perhaps you could actually share details about your discoveries...? Looks like its just DatabaseAuthorizer that needs to move.
Don Olmstead
Comment 3 2017-08-03 13:46:53 PDT
Created attachment 317147 [details] Patch Hopefully fixing xcode
Don Olmstead
Comment 4 2017-08-03 13:51:55 PDT
Grr wrong bug. Ignore this
Note You need to log in before you can comment on or make changes to this bug.