Bug 175183

Summary: WebDriver: Implement page load strategy
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174618    
Bug Blocks: 166679    
Attachments:
Description Flags
Patch
bburg: review+
Patch for landing none

Carlos Garcia Campos
Reported 2017-08-04 03:54:35 PDT
https://w3c.github.io/webdriver/webdriver-spec.html#navigation
Attachments
Patch (30.37 KB, patch)
2017-08-04 06:04 PDT, Carlos Garcia Campos 		bburg: review+
DetailsFormatted DiffDiff
Patch for landing (30.05 KB, patch)
2017-08-05 02:50 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-08-04 06:04:22 PDT
Created attachment 317239 [details] Patch
Blaze Burg
Comment 2 2017-08-04 11:12:52 PDT
Comment on attachment 317239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317239&action=review r=me, great work. Please send through EWS before landing. > Source/WebKit/ChangeLog:8 > + Split pending navigation maps into normal and eager, and one or the other depending on the received page load strategy. Nit: ... and *use* one or the other ... You don't actually say why two maps are needed here. > Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:459 > +static void finishPendingNavigationsWithTimeoutFailure(HashMap<uint64_t, RefPtr<Inspector::BackendDispatcher::CallbackBase>>& map) Nit: I prefer a name like "respondToPendingNavigationCallbacksWithTimeout" or something. > Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:519 > + Inspector::Protocol::Automation::PageLoadStrategy pageLoadStrategy = defaultPageLoadStrategy; Okay, we have this same code three times. Can you extract it?
Carlos Garcia Campos
Comment 3 2017-08-05 02:50:23 PDT
Created attachment 317334 [details] Patch for landing
Carlos Garcia Campos
Comment 4 2017-08-05 04:14:44 PDT
Committed r220317: <http://trac.webkit.org/changeset/220317>
Radar WebKit Bug Importer
Comment 5 2017-08-05 04:15:56 PDT
<rdar://problem/33740067>
Note You need to log in before you can comment on or make changes to this bug.