Bug 175241

Summary:

Add ServiceWorkerJob

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

ASSIGNED

Severity:

Normal

CC:

aestes, buildbot, cdumez, commit-queue, jrburke, olivier, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=174541

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Landing run	none
Landing run	none

Brady Eidson

Reported 2017-08-05 21:22:17 PDT

Add ServiceWorkerJob and job queue This will also include scheduling the very first job - The "register" job

Attachments
Patch (57.18 KB, patch) 2017-08-09 16:57 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (57.14 KB, patch) 2017-08-09 20:18 PDT, Brady Eidson	thorton: review+	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (982.24 KB, application/zip) 2017-08-09 22:03 PDT, Build Bot	no flags	Details
Landing run (57.49 KB, patch) 2017-08-10 10:54 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Landing run (57.15 KB, patch) 2017-08-10 10:56 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-08-09 16:24:03 PDT

To keep the patch small, I'll just be adding ServiceWorkerJob and using it for one immediate promise rejection. We'll queue jobs in the next patch.

Brady Eidson

Comment 2 2017-08-09 16:57:12 PDT

Created attachment 317761 [details] Patch

Brady Eidson

Comment 3 2017-08-09 20:18:23 PDT

Created attachment 317778 [details] Patch

Build Bot

Comment 4 2017-08-09 22:03:18 PDT

Comment on attachment 317778 [details] Patch Attachment 317778 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4287820 New failing tests: fast/dom/insertedIntoDocument-sibling.html

Build Bot

Comment 5 2017-08-09 22:03:19 PDT

Created attachment 317783 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Brady Eidson

Comment 6 2017-08-09 22:45:29 PDT

(In reply to Build Bot from comment #5) > Created attachment 317783 [details] > Archive of layout-test-results from ews125 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5 The crashing test is definitely not the result of this patch.

Tim Horton

Comment 7 2017-08-10 10:46:29 PDT

Comment on attachment 317778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317778&action=review > Source/WebCore/workers/ServiceWorkerJob.cpp:48 > +#ifndef NDEBUG You shouldn't need these. > Source/WebCore/workers/ServiceWorkerJob.cpp:55 > +#ifndef NDEBUG You shouldn't need these. > Source/WebCore/workers/ServiceWorkerJob.h:64 > +#ifndef NDEBUG ASSERT_DISABLED

Brady Eidson

Comment 8 2017-08-10 10:54:08 PDT

Created attachment 317822 [details] Landing run

Brady Eidson

Comment 9 2017-08-10 10:56:58 PDT

Created attachment 317823 [details] Landing run

WebKit Commit Bot

Comment 10 2017-08-10 12:28:30 PDT

Comment on attachment 317823 [details] Landing run Clearing flags on attachment: 317823 Committed r220539: <http://trac.webkit.org/changeset/220539>

Note You need to log in before you can comment on or make changes to this bug.