Bug 176082

Summary: Implement all of "Register" right up until where the script is fetched
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174541
Attachments:
Description Flags
EWS run
none
Patch
none
Patch none

Brady Eidson
Reported 2017-08-29 16:51:22 PDT
Implement all of "Register" right up until where the script is fetched This includes tests for all the exceptions that can occur along the way.
Attachments
EWS run (54.62 KB, patch)
2017-08-29 20:32 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (63.38 KB, patch)
2017-08-30 09:32 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (63.38 KB, patch)
2017-08-30 10:58 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-08-29 20:32:59 PDT
Created attachment 319326 [details] EWS run
Brady Eidson
Comment 2 2017-08-30 09:32:09 PDT
Created attachment 319372 [details] Patch
Andy Estes
Comment 3 2017-08-30 10:35:23 PDT
Comment on attachment 319372 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319372&action=review > Source/WebCore/workers/service/ServiceWorkerContainer.cpp:170 > + ScopeGuard guard([this, job = &job] { Why not just capture &job? > Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:37 > +{ > +} Do you need to call suspendIfNeeded() here now that this is an ActiveDOMObject?
Brady Eidson
Comment 4 2017-08-30 10:41:23 PDT
(In reply to Andy Estes from comment #3) > Comment on attachment 319372 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319372&action=review > > > Source/WebCore/workers/service/ServiceWorkerContainer.cpp:170 > > + ScopeGuard guard([this, job = &job] { > > Why not just capture &job? Oh, no reason. (Leftovers from a previous iteration of this function) > > Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:37 > > +{ > > +} > > Do you need to call suspendIfNeeded() here now that this is an > ActiveDOMObject? The answer is no, but simply because there is still no code path that actually ends up in properly resolving the promise with a new registration. Once there is such a code path, I sure will!
Brady Eidson
Comment 5 2017-08-30 10:58:13 PDT
Created attachment 319379 [details] Patch
WebKit Commit Bot
Comment 6 2017-08-30 12:40:39 PDT
Comment on attachment 319379 [details] Patch Clearing flags on attachment: 319379 Committed r221392: <http://trac.webkit.org/changeset/221392>
WebKit Commit Bot
Comment 7 2017-08-30 12:40:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-08-30 12:40:57 PDT
<rdar://problem/34169273>
Note You need to log in before you can comment on or make changes to this bug.