Bug 177455

Summary: Make StoredCredentials an enum class and rename its header
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, ggaren, koivisto, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177474    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-09-25 12:29:11 PDT
Make StoredCredentials an enum class and rename its header for clarity. This was error-prone because 0 meant "allow" and and 1 meant "do not allow". It was trivial to convert it to a boolean by mistake and get the opposite behavior.
Attachments
Patch (120.97 KB, patch)
2017-09-25 12:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.34 KB, patch)
2017-09-26 10:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-09-25 12:31:49 PDT
Created attachment 321720 [details] Patch
WebKit Commit Bot
Comment 2 2017-09-25 14:17:48 PDT
Comment on attachment 321720 [details] Patch Clearing flags on attachment: 321720 Committed r222467: <http://trac.webkit.org/changeset/222467>
WebKit Commit Bot
Comment 3 2017-09-25 14:17:50 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 4 2017-09-26 09:59:34 PDT
Forgot enum *class*.
Chris Dumez
Comment 5 2017-09-26 10:02:47 PDT
Created attachment 321830 [details] Patch
WebKit Commit Bot
Comment 6 2017-09-26 13:36:33 PDT
Comment on attachment 321830 [details] Patch Clearing flags on attachment: 321830 Committed r222519: <http://trac.webkit.org/changeset/222519>
WebKit Commit Bot
Comment 7 2017-09-26 13:36:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:18:04 PDT
<rdar://problem/34692984>
Note You need to log in before you can comment on or make changes to this bug.