Bug 177865

Summary: [JHBuild][GTK][WKE] Circular dependency between harfbuzz and freetype6
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2017-10-04 04:22:03 PDT
On the JHBuild for the GTK+ and WPE ports we are building both harfbuzz and freetype6. The issue is that there is a circular dependency between harfbuzz and freetype6 that can cause issues depending on what the libraries the developer has installed. This is because the switch to detect this features is automatic enabled depending on the headers it detects. The support for harfbuzz on freetype6 is an optional feature that most distros (fedora, debian, openembedded....) seems to disable by building freetype6 with --with-harfbuzz=no Let's do the same
Attachments
Patch (3.39 KB, patch)
2017-10-04 04:31 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2017-10-04 07:35 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2017-10-04 04:31:13 PDT
Created attachment 322652 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2017-10-04 07:35:04 PDT
Created attachment 322668 [details] Patch Re-EWS
WebKit Commit Bot
Comment 3 2017-10-04 09:00:02 PDT
The commit-queue encountered the following flaky tests while processing attachment 322668 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2017-10-04 09:00:12 PDT
The commit-queue encountered the following flaky tests while processing attachment 322668 [details]: media/modern-media-controls/seek-backward-support/seek-backward-support.html bug 174916 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2017-10-04 09:54:20 PDT
Comment on attachment 322668 [details] Patch Clearing flags on attachment: 322668 Committed r222851: <http://trac.webkit.org/changeset/222851>
WebKit Commit Bot
Comment 6 2017-10-04 09:54:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-04 09:57:19 PDT
<rdar://problem/34813726>
Note You need to log in before you can comment on or make changes to this bug.