Bug 178374

Summary: ServiceWorkerRegistration should subclass RefCounted<>
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174541
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2017-10-16 20:41:24 PDT
ServiceWorkerRegistration should subclass RefCounted<>.
Attachments
Patch (2.12 KB, patch)
2017-10-16 20:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.12 KB, patch)
2017-10-16 21:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-10-16 20:44:27 PDT
Created attachment 323982 [details] Patch
Ryosuke Niwa
Comment 2 2017-10-16 20:47:44 PDT
Comment on attachment 323982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323982&action=review > Source/WebCore/workers/service/ServiceWorkerRegistration.h:40 > -class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject { > +class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject, public RefCounted<ServiceWorkerRegistration> { We typically put RefCounted as the first class listed in the inheritance list.
Chris Dumez
Comment 3 2017-10-16 21:32:38 PDT
Created attachment 323991 [details] Patch
WebKit Commit Bot
Comment 4 2017-10-16 22:12:56 PDT
Comment on attachment 323991 [details] Patch Clearing flags on attachment: 323991 Committed r223457: <https://trac.webkit.org/changeset/223457>
WebKit Commit Bot
Comment 5 2017-10-16 22:12:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-10-16 22:14:18 PDT
<rdar://problem/35022851>
Note You need to log in before you can comment on or make changes to this bug.