Bug 178497

Summary:

Implement ServiceWorkerRegistration.scope / updateViaCache

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, ben, buildbot, commit-queue, esprehn+autocc, ggaren, kondapallykalyan, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar, WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=174541

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-10-18 18:31:44 PDT

Implement ServiceWorkerRegistration.scope / updateViaCache.

Attachments
Patch (25.72 KB, patch) 2017-10-18 18:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (25.89 KB, patch) 2017-10-18 19:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (25.24 KB, patch) 2017-10-18 19:56 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-10-18 18:36:34 PDT

Created attachment 324194 [details] Patch

youenn fablet

Comment 2 2017-10-18 18:57:52 PDT

Comment on attachment 324194 [details] Patch LGTM once the bots are happy. View in context: https://bugs.webkit.org/attachment.cgi?id=324194&action=review > Source/WebCore/workers/service/ServiceWorkerRegistration.h:66 > virtual ScriptExecutionContext* scriptExecutionContext() const; Can you mark these two as final as well? > Source/WebCore/workers/service/ServiceWorkerRegistrationData.h:74 > + decoder >> updateViaCache; I wonder whether decoder >> key >> identifier >> scopeURL >> updateViaCache would be something we want. That would match the encoder version nicely but we do not return as early and it is less debuggable. > Source/WebCore/workers/service/ServiceWorkerRegistrationData.h:78 > + return {{ WTFMove(*key), WTFMove(*identifier), WTFMove(*scopeURL), WTFMove(*updateViaCache) }}; Does style say to put a space between {{ or }}?

Chris Dumez

Comment 3 2017-10-18 19:02:36 PDT

Created attachment 324196 [details] Patch

Chris Dumez

Comment 4 2017-10-18 19:56:27 PDT

Created attachment 324204 [details] Patch

WebKit Commit Bot

Comment 5 2017-10-18 20:29:55 PDT

Comment on attachment 324204 [details] Patch Clearing flags on attachment: 324204 Committed r223652: <https://trac.webkit.org/changeset/223652>

WebKit Commit Bot

Comment 6 2017-10-18 20:29:57 PDT

All reviewed patches have been landed. Closing bug.