Bug 178767

Summary:

Web Inspector: preserve Recordings for each Canvas after closing the Canvas tab

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, commit-queue, inspector-bugzilla-changes, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

177606

Bug Blocks:

173807, 175485

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Patch	none
Patch	none

Devin Rousso

Reported 2017-10-24 18:25:40 PDT

We currently associate a Canvas to a Recording via its `_source`, but not the other way around. Doing so would allow us to reclaim recordings even after the Canvas tab is closed, as the Recordings are stored in the Model layer, which is not does not rely on the UI.

Attachments
Patch (9.04 KB, patch) 2017-10-24 18:27 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.23 MB, application/zip) 2017-10-24 19:26 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (2.03 MB, application/zip) 2017-10-24 19:47 PDT, Build Bot	no flags	Details
Patch (9.81 KB, patch) 2017-10-24 21:28 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (11.66 KB, patch) 2017-10-24 23:45 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-10-24 18:27:40 PDT

Created attachment 324769 [details] Patch

Build Bot

Comment 2 2017-10-24 19:26:58 PDT

Comment on attachment 324769 [details] Patch Attachment 324769 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4978567 New failing tests: inspector/canvas/requestContent-webgl2.html inspector/canvas/resolveCanvasContext-webgl2.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/requestNode.html inspector/canvas/requestContent-2d.html inspector/canvas/requestShaderSource.html inspector/canvas/memory.html inspector/canvas/setShaderProgramDisabled.html inspector/canvas/resolveCanvasContext-2d.html inspector/canvas/recording-2d.html inspector/canvas/recording-webgl.html inspector/canvas/resolveCanvasContext-webgpu.html inspector/css/pseudo-element-matches.html inspector/canvas/resolveCanvasContext-webgl.html inspector/canvas/requestContent-webgl.html inspector/canvas/updateShader.html inspector/canvas/create-context-webgl.html

Build Bot

Comment 3 2017-10-24 19:26:59 PDT

Created attachment 324779 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-10-24 19:47:49 PDT

Comment on attachment 324769 [details] Patch Attachment 324769 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4978630 New failing tests: inspector/canvas/requestContent-webgl2.html inspector/canvas/resolveCanvasContext-webgl2.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/requestNode.html inspector/canvas/requestContent-2d.html inspector/canvas/requestShaderSource.html inspector/canvas/memory.html inspector/canvas/setShaderProgramDisabled.html inspector/canvas/resolveCanvasContext-2d.html inspector/canvas/recording-2d.html inspector/canvas/recording-webgl.html inspector/canvas/resolveCanvasContext-webgpu.html inspector/css/pseudo-element-matches.html inspector/canvas/resolveCanvasContext-webgl.html inspector/canvas/requestContent-webgl.html inspector/canvas/updateShader.html inspector/canvas/create-context-webgl.html

Build Bot

Comment 5 2017-10-24 19:47:50 PDT

Created attachment 324780 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Devin Rousso

Comment 6 2017-10-24 21:28:10 PDT

Created attachment 324793 [details] Patch

Blaze Burg

Comment 7 2017-10-24 22:34:02 PDT

Comment on attachment 324793 [details] Patch r=me v.nice. is there anything we want to test here? It seems too straightforward really...

Radar WebKit Bug Importer

Comment 8 2017-10-24 22:34:49 PDT

<rdar://problem/35167239>

Devin Rousso

Comment 9 2017-10-24 23:45:11 PDT

Created attachment 324798 [details] Patch Unreviewed addition: added assertions to existing test utility file that the recording is listed on the related canvas.

WebKit Commit Bot

Comment 10 2017-10-25 00:39:09 PDT

Comment on attachment 324798 [details] Patch Clearing flags on attachment: 324798 Committed r223952: <https://trac.webkit.org/changeset/223952>

WebKit Commit Bot

Comment 11 2017-10-25 00:39:10 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.