Bug 178806

Summary: Web Inspector: Canvas Tab: canvas path components from old page stick around when page is reloaded
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
URL: http://acko.net
See Also: https://bugs.webkit.org/show_bug.cgi?id=178804
Bug Depends on:    
Bug Blocks: 175485    
Attachments:
Description Flags
Screenshot
none
Patch
none
Patch none

Blaze Burg
Reported 2017-10-25 10:15:03 PDT
Created attachment 324841 [details] Screenshot STR: 1. Load acko.net 2. Open Inspector, Canvases Tab 3. Reload the page several times => Now I have multiple Canvas 2, Canvas 3 path components
Attachments
Screenshot (426.10 KB, image/png)
2017-10-25 10:15 PDT, Blaze Burg 		no flags
Details
Patch (16.30 KB, patch)
2017-10-25 15:49 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (16.81 KB, patch)
2017-10-26 18:24 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-25 10:15:18 PDT
<rdar://problem/35176360>
Devin Rousso
Comment 2 2017-10-25 15:49:01 PDT
Created attachment 324912 [details] Patch
Blaze Burg
Comment 3 2017-10-26 16:34:10 PDT
Comment on attachment 324912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324912&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + You never really explained why the code was wrong or what the fix does differently. > Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:185 > + for (let recording of canvas.recordingCollection.items) { I would comment here that we are converting the gone canvas' recordings to be imported recordings.
Devin Rousso
Comment 4 2017-10-26 18:24:02 PDT
Created attachment 325093 [details] Patch Added comments. No change in logic.
WebKit Commit Bot
Comment 5 2017-10-26 19:20:08 PDT
Comment on attachment 325093 [details] Patch Clearing flags on attachment: 325093 Committed r224081: <https://trac.webkit.org/changeset/224081>
WebKit Commit Bot
Comment 6 2017-10-26 19:20:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.