Bug 179750

Summary: REGRESSION(r224887): GCC 5 build broken
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebCore Misc.Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, commit-queue, jer.noble, mcatanzaro, Ms2ger, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179706
Bug Depends on:    
Bug Blocks: 178894    
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-11-15 16:54:23 PST
r224887 avoids relying on implementation-defined behavior (multichar constants). We don't want to roll out that commit. But it also breaks the build with GCC 5. We'd like to continue supporting GCC 5 in trunk for another half a year, as per https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy. This is actually pretty difficult and messy, but I think I have a solution that works for GCC 5 without sacrificing Jer's nice constexpr constructor when using newer compilers.
Attachments
Patch (5.29 KB, patch)
2017-11-15 17:12 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-11-15 17:12:13 PST
Created attachment 327037 [details] Patch
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 2 2017-11-16 00:00:58 PST
Alternatively, would it be possible to add a no-argument constructor that initializes to zero? FourCC { 0 } would still be broken, but the alternative would be less ugly.
Carlos Alberto Lopez Perez
Comment 3 2017-11-16 06:23:06 PST
Comment on attachment 327037 [details] Patch Jer .. any opinion on this? I will r+ it tomorrow if there isn't concern about this patch. Its a build fix, so it has a bit of urgency.
Michael Catanzaro
Comment 4 2017-11-16 07:25:10 PST
(In reply to Ms2ger from comment #2) > Alternatively, would it be possible to add a no-argument constructor that > initializes to zero? FourCC { 0 } would still be broken, but the alternative > would be less ugly. Seems like a good idea. Let's see what Jer thinks before I spend more time on this, though, because this was harder than it looks and I don't care to admit how much time I spent on it. :P
Jer Noble
Comment 5 2017-11-16 13:52:00 PST
Comment on attachment 327037 [details] Patch This looks fine.
Michael Catanzaro
Comment 6 2017-11-16 15:08:42 PST
(In reply to Ms2ger from comment #2) > Alternatively, would it be possible to add a no-argument constructor that > initializes to zero? FourCC { 0 } would still be broken, but the alternative > would be less ugly. Although it's ugly, I decided to stick with the current approach to avoid needing to define the no-argument constructor in the non-GCC 5 case. This way, when we delete the fallback code, we won't have the extra constructor left over.
WebKit Commit Bot
Comment 7 2017-11-16 15:28:03 PST
Comment on attachment 327037 [details] Patch Clearing flags on attachment: 327037 Committed r224937: <https://trac.webkit.org/changeset/224937>
WebKit Commit Bot
Comment 8 2017-11-16 15:28:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-11-16 15:29:30 PST
<rdar://problem/35600883>
Note You need to log in before you can comment on or make changes to this bug.