Bug 179817

Summary: [WPE] Build C API tests
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173770    
Bug Blocks:    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-11-17 05:47:54 PST
They aren't build for WPE.
Attachments
Patch (16.67 KB, patch)
2017-11-17 05:49 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-11-17 05:49:28 PST
Created attachment 327165 [details] Patch
Carlos Garcia Campos
Comment 2 2017-11-17 06:12:06 PST
This is not expected to build since it depends on two other patches.
Michael Catanzaro
Comment 3 2017-11-17 07:35:16 PST
Comment on attachment 327165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327165&action=review > Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:68 > + if (m_window) > + delete m_window; delete is NULL-safe, so remove the if (m_window) check. > Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:89 > + // FIXME: implement this. What happened to using notImplemented()? :D
Carlos Garcia Campos
Comment 4 2017-11-17 08:29:32 PST
Comment on attachment 327165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327165&action=review >> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:68 >> + delete m_window; > > delete is NULL-safe, so remove the if (m_window) check. Right! >> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:89 >> + // FIXME: implement this. > > What happened to using notImplemented()? :D notImplemented() is WebCore API.
Carlos Garcia Campos
Comment 5 2017-11-20 01:51:16 PST
Committed r225046: <https://trac.webkit.org/changeset/225046>
Note You need to log in before you can comment on or make changes to this bug.