Bug 179951

Summary: [WPE] Stop building Wayland in JHBuild moduleset
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WPE WebKitAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, clopez, commit-queue, mcatanzaro, zan
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 178894, 178896    
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2017-11-22 09:19:23 PST
Upgrade Wayland in JHBuild moduleset. This is needed for EGLGetDisplay() to work on my computer.
Attachments
Patch (3.78 KB, patch)
2017-11-22 09:35 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2017-11-22 12:04 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-11-22 09:25:33 PST
If I'm not wrong wayland is not needed at all to run the tests, becase we use the headless backend, so wayland is just a dep of dyz, and we don't need to build it ourselves, so I would just remove it from the jhbuild moduleset. Unless I'm missing something. . .
Michael Catanzaro
Comment 2 2017-11-22 09:29:17 PST
Yes,since Wayland is not used for running tests, and since it does not seem to depend on anything in the JHBuild moduleset, I think we can remove it safely without having to worry that the system version of Wayland might use libraries in the jhbuild environment (which would be unsafe).
Michael Catanzaro
Comment 3 2017-11-22 09:29:39 PST
It's also a dep of wpe-mesa, but that does not matter. It would only be a problem if the dependency was reversed.
Michael Catanzaro
Comment 4 2017-11-22 09:35:04 PST
Created attachment 327457 [details] Patch
Michael Catanzaro
Comment 5 2017-11-22 11:55:14 PST
Zan thinks Wayland can affect OpenGL tests, even using headless mode, so I'll upgrade it instead.
Michael Catanzaro
Comment 6 2017-11-22 12:04:35 PST
Created attachment 327468 [details] Patch
Michael Catanzaro
Comment 7 2017-11-22 15:01:23 PST
Comment on attachment 327468 [details] Patch Unsetting r? because Carlos Lopez thinks this is a bad idea.
Michael Catanzaro
Comment 8 2017-11-22 15:05:54 PST
Comment on attachment 327457 [details] Patch Setting r? on this one, since I suspect this is the one we'll have to go with... even if it means we don't get consistent results for WebGL tests. (But I'm still not clear as to why Wayland would affect headless mode results.)
Carlos Alberto Lopez Perez
Comment 9 2017-11-22 16:24:02 PST
(In reply to Michael Catanzaro from comment #5) > Zan thinks Wayland can affect OpenGL tests, even using headless mode, so > I'll upgrade it instead. mmmm... how this can happen?
Michael Catanzaro
Comment 10 2017-11-22 16:33:39 PST
I don't know.
Michael Catanzaro
Comment 11 2017-11-27 12:22:45 PST
(In reply to Carlos Alberto Lopez Perez from comment #9) > (In reply to Michael Catanzaro from comment #5) > > Zan thinks Wayland can affect OpenGL tests, even using headless mode, so > > I'll upgrade it instead. > > mmmm... how this can happen? Zan, any comment on this? If Wayland version can still somehow affect layout tests even though we now have headless mode, then I suggest we build Weston inside the JHBuild environment, and expect developers using the JHBuild environment to use that version of Weston. Otherwise, I think we should commit my patch to drop Wayland from the JHBuild environment.
Michael Catanzaro
Comment 12 2017-11-29 16:49:18 PST
OK, I was supposed to ensure this didn't get stalled... r?
Zan Dobersek
Comment 13 2017-11-29 23:39:29 PST
(In reply to Michael Catanzaro from comment #11) > (In reply to Carlos Alberto Lopez Perez from comment #9) > > (In reply to Michael Catanzaro from comment #5) > > > Zan thinks Wayland can affect OpenGL tests, even using headless mode, so > > > I'll upgrade it instead. > > > > mmmm... how this can happen? > > Zan, any comment on this? > It apparently never happened. False memories on my side.
WebKit Commit Bot
Comment 14 2017-11-30 07:01:56 PST
Comment on attachment 327457 [details] Patch Clearing flags on attachment: 327457 Committed r225327: <https://trac.webkit.org/changeset/225327>
WebKit Commit Bot
Comment 15 2017-11-30 07:01:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.