Bug 180013

Summary: WPT tests for MathML lengths fail
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: dbarton, ews-watchlist, rbuis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=85730
Bug Depends on:    
Bug Blocks: 179110    
Attachments:
Description Flags
Patch none

Frédéric Wang (:fredw)
Reported 2017-11-25 07:13:34 PST
* http://www.w3c-test.org/mathml/relations/css-styling/lengths-1.html * http://www.w3c-test.org/mathml/relations/css-styling/lengths-3.html The "unitless" tests fail because mathsize="5" and mathsize="20.0" is not interpreted as "500%" and "2000%". See https://www.w3.org/TR/MathML/chapter2.html#fund.units * http://www.w3c-test.org/mathml/relations/css-styling/lengths-2.html This test fails because of limitation the mpadded element ( https://bugs.webkit.org/show_bug.cgi?id=85730 ), probably the lack of support for pseudo units and for negative lengths. See https://www.w3.org/TR/MathML/chapter3.html#presm.mpadded
Attachments
Patch (3.93 KB, patch)
2019-02-22 00:16 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2019-02-22 00:16:09 PST
Created attachment 362701 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2019-02-22 00:46:07 PST
Comment on attachment 362701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362701&action=review > Source/WebCore/ChangeLog:3 > + WPT tests for MathML lengths fail This actually fixes the mathsize unitless and tests length-1 and length-3. I guess it could be in a different bug with better title/desc. At least we should have a bug open to track the remaining length-2 failure. (Note: I wonder if the support for (nonzero) unitless values should be removed from MathML) > Source/WebCore/ChangeLog:8 > + Covert unitless lengths to percentage values to correct the computed convert
Rob Buis
Comment 3 2019-02-22 01:42:01 PST
(In reply to Frédéric Wang (:fredw) from comment #2) > Comment on attachment 362701 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362701&action=review > > > Source/WebCore/ChangeLog:3 > > + WPT tests for MathML lengths fail > > This actually fixes the mathsize unitless and tests length-1 and length-3. I > guess it could be in a different bug with better title/desc. At least we > should have a bug open to track the remaining length-2 failure. Sure, I opened https://bugs.webkit.org/show_bug.cgi?id=194940 instead and removed the review flag for this one. > (Note: I wonder if the support for (nonzero) unitless values should be > removed from MathML) > > > Source/WebCore/ChangeLog:8 > > + Covert unitless lengths to percentage values to correct the computed > > convert Fixed.
Rob Buis
Comment 4 2019-03-01 05:52:26 PST
Not working on this ATM, but only failure left: * http://www.w3c-test.org/mathml/relations/css-styling/lengths-2.html This test fails because of limitation the mpadded element ( https://bugs.webkit.org/show_bug.cgi?id=85730 ), probably the lack of support for pseudo units and for negative lengths. See https://www.w3.org/TR/MathML/chapter3.html#presm.mpadded
Note You need to log in before you can comment on or make changes to this bug.