Bug 180780

Summary: [WPE] WebCrypto should be a public option.
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WPE WebKitAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bugs-noreply, cgarcia, clopez, commit-queue, ews-watchlist, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179009    
Attachments:
Description Flags
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2017-12-13 16:21:35 PST
On bug 179009 the WebCrypto has been turned into a private option. On top of that the dependency on libtasn1 and gcrypt > 1.6.0 has been forced even if one doesn't enable web_crypto by default. I think this is wrong. ENABLE_WEB_CRYPTO should remain a public option for WPE (at least as long as it is also public one on the GTK port). Also, when this option is disabled the build dependencies on libtasn1 or gcrypt > 1.6.0 is not needed. Making our build dependencies soft, makes easier to build WPE en embedded systems. Please don't raise them more than strictly needed. Also having public options allows external developers building systems to disable feature without having to dive into our cmake code. Disabling features when don't needed allows for a lower footprint. Let's try to keep public the options that make sense.
Attachments
Patch (2.46 KB, patch)
2017-12-13 16:36 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2017-12-13 16:45 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2017-12-13 16:36:53 PST
Created attachment 329283 [details] Patch
EWS Watchlist
Comment 2 2017-12-13 16:38:51 PST
Attachment 329283 [details] did not pass style-queue: ERROR: Source/cmake/OptionsWPE.cmake:86: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Alberto Lopez Perez
Comment 3 2017-12-13 16:45:18 PST
Created attachment 329286 [details] Patch fix style
WebKit Commit Bot
Comment 4 2017-12-13 17:45:07 PST
Comment on attachment 329286 [details] Patch Clearing flags on attachment: 329286 Committed r225888: <https://trac.webkit.org/changeset/225888>
WebKit Commit Bot
Comment 5 2017-12-13 17:45:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.