Bug 181392

Summary: Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html is a flaky failure on macOS and iOS
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, jlewis3, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Patch
none
Patch none

Ryan Haddad
Reported 2018-01-08 10:16:06 PST
The following layout test is flaky on on macOS and iOS imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html Probable cause: Unknown. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Ffetch-waits-for-activate.https.html --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https-actual.txt @@ -1,3 +1,4 @@ -PASS Fetch events should wait for the activate event to complete. +FAIL Fetch events should wait for the activate event to complete. assert_unreached: unexpected rejection: assert_equals: active worker should be in activated state expected "activated" but got "activating" Reached unreachable code +
Attachments
Patch (10.69 KB, patch)
2018-02-06 12:46 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.74 KB, patch)
2018-02-06 13:37 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.77 MB, application/zip)
2018-02-06 14:42 PST, EWS Watchlist 		no flags
Details
Patch (11.67 KB, patch)
2018-02-06 15:01 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.71 KB, patch)
2018-02-06 15:03 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-09 13:28:49 PST
<rdar://problem/36384136>
Matt Lewis
Comment 2 2018-01-10 13:54:56 PST
Marked as Flaky: https://trac.webkit.org/changeset/226730/webkit
Chris Dumez
Comment 3 2018-02-06 12:01:39 PST
This looks very similar to Bug 181698.
Chris Dumez
Comment 4 2018-02-06 12:03:25 PST
(In reply to Chris Dumez from comment #3) > This looks very similar to Bug 181698. Unfortunately this fix went into r227070 and the flakiness dashboard still shows failures as of r228156.
Chris Dumez
Comment 5 2018-02-06 12:46:55 PST
Created attachment 333205 [details] Patch
Chris Dumez
Comment 6 2018-02-06 13:37:00 PST
Created attachment 333208 [details] Patch
EWS Watchlist
Comment 7 2018-02-06 14:42:10 PST
Comment on attachment 333208 [details] Patch Attachment 333208 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6387666 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html imported/w3c/web-platform-tests/service-workers/service-worker/fetch-csp.https.html
EWS Watchlist
Comment 8 2018-02-06 14:42:12 PST
Created attachment 333220 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Chris Dumez
Comment 9 2018-02-06 15:01:35 PST
Created attachment 333224 [details] Patch
Chris Dumez
Comment 10 2018-02-06 15:03:55 PST
Created attachment 333225 [details] Patch
youenn fablet
Comment 11 2018-02-06 15:39:25 PST
Comment on attachment 333225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333225&action=review > Source/WebKit/ChangeLog:15 > + the ServiceWorkerClientFetch callbacks schedule tasks to the runloop too. Let's try to remove these callOnMainThread in the future. For now, it is good to be consistent.
WebKit Commit Bot
Comment 12 2018-02-06 16:03:10 PST
Comment on attachment 333225 [details] Patch Clearing flags on attachment: 333225 Committed r228198: <https://trac.webkit.org/changeset/228198>
WebKit Commit Bot
Comment 13 2018-02-06 16:03:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.