Bug 181627

Summary:

[WebAuthN] Implement dummy WebAuthN IDLs

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, cdumez, commit-queue, esprehn+autocc, ews-watchlist, jiewen_tan, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	none
Patch	achristensen: review+
Patch for landing	commit-queue: commit-queue-

Jiewen Tan

Reported 2018-01-12 20:08:02 PST

Implement dummy WebAuthN IDLs.

Attachments
Patch (76.68 KB, patch) 2018-01-12 20:16 PST, Jiewen Tan	no flags	Details Formatted Diff Diff
Patch (77.61 KB, patch) 2018-01-12 23:14 PST, Jiewen Tan	achristensen: review+	Details Formatted Diff Diff
Patch for landing (76.95 KB, patch) 2018-01-16 11:48 PST, Jiewen Tan	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jiewen Tan

Comment 1 2018-01-12 20:08:26 PST

<rdar://problem/36459864>

Jiewen Tan

Comment 2 2018-01-12 20:16:02 PST

Created attachment 331271 [details] Patch

Jiewen Tan

Comment 3 2018-01-12 23:14:09 PST

Created attachment 331277 [details] Patch

Alex Christensen

Comment 4 2018-01-13 12:58:54 PST

Comment on attachment 331277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331277&action=review > Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:37 > + RefPtr<ArrayBuffer> authenticatorData(); I think these should just return a pointer. > Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:42 > + RefPtr<ArrayBuffer> m_authenticatorData; Can we not make any of these Ref's? > Source/WebCore/Modules/webauthn/PublicKeyCredential.idl:28 > +// enum UserVerificationRequirement { Can we add this later, rather than adding commented things? > Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h:61 > + unsigned long timeout; Could we give these initializer lists to avoid uninitialized members? > Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.idl:31 > +// enum AttestationConveyancePreference { ditto

Jiewen Tan

Comment 5 2018-01-14 16:48:18 PST

Comment on attachment 331277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331277&action=review Thanks Alex for r+ this patch. >> Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:37 >> + RefPtr<ArrayBuffer> authenticatorData(); > > I think these should just return a pointer. May I ask why a pointer is better than RefPtr? >> Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:42 >> + RefPtr<ArrayBuffer> m_authenticatorData; > > Can we not make any of these Ref's? If not Ref's, what data type should be there? >> Source/WebCore/Modules/webauthn/PublicKeyCredential.idl:28 >> +// enum UserVerificationRequirement { > > Can we add this later, rather than adding commented things? Certainly. >> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h:61 >> + unsigned long timeout; > > Could we give these initializer lists to avoid uninitialized members? Certainly. >> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.idl:31 >> +// enum AttestationConveyancePreference { > > ditto Fixed.

Jiewen Tan

Comment 6 2018-01-16 11:48:45 PST

Created attachment 331409 [details] Patch for landing

Jiewen Tan

Comment 7 2018-01-16 14:27:50 PST

Comment on attachment 331409 [details] Patch for landing The Win EWS bot seems to have some issues. cq+ regardless of it.

WebKit Commit Bot

Comment 8 2018-01-16 14:53:00 PST

Comment on attachment 331409 [details] Patch for landing Rejecting attachment 331409 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 331409, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: org/git/WebKit 4b0009cc0a2..958c295cde9 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 227003 = 4b0009cc0a2bd83b4e417c6c836c36dba18b913d r227004 = 958c295cde97fe554d73518321cc39caeb20eb22 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/6098675

Jiewen Tan

Comment 9 2018-01-16 15:08:50 PST

Committed r227007: <https://trac.webkit.org/changeset/227007>

Note You need to log in before you can comment on or make changes to this bug.