Bug 182682

Summary: [WinCairo] WebKit2_C.h should be included for TestWebKit
Product: WebKit Reporter: Yousuke Kimoto <Yousuke.Kimoto>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, darin, don.olmstead, ews-watchlist, pvollan, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174003    
Attachments:
Description Flags
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews206 for win-future
none
bz182682-2.patch none

Yousuke Kimoto
Reported 2018-02-11 21:43:28 PST
WinCairo WebKit requires WebKIt2_C.h to build TestWebKit.
Attachments
Patch (1.08 KB, patch)
2018-02-11 21:47 PST, Yousuke Kimoto 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (11.49 MB, application/zip)
2018-02-12 00:14 PST, EWS Watchlist 		no flags
Details
bz182682-2.patch (1.93 KB, patch)
2018-02-13 05:10 PST, Yousuke Kimoto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yousuke Kimoto
Comment 1 2018-02-11 21:47:37 PST
Created attachment 333579 [details] Patch
Yousuke Kimoto
Comment 2 2018-02-11 23:38:04 PST
Since WebKit2_C is needed to be included in case of the wincairo webkit build, an option to specify the build mode is required. I'll fix the issue.
EWS Watchlist
Comment 3 2018-02-12 00:14:13 PST
Comment on attachment 333579 [details] Patch Attachment 333579 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6461547 New failing tests: http/tests/preload/onerror_event.html
EWS Watchlist
Comment 4 2018-02-12 00:14:23 PST
Created attachment 333584 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Yousuke Kimoto
Comment 5 2018-02-13 05:10:40 PST
Created attachment 333683 [details] bz182682-2.patch
Yusuke Suzuki
Comment 6 2018-02-22 19:31:54 PST
Comment on attachment 333683 [details] bz182682-2.patch View in context: https://bugs.webkit.org/attachment.cgi?id=333683&action=review > Tools/TestWebKitAPI/config.h:64 > +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT)) Why doesn't `PLATFORM(WIN_CAIRO)` work?
Yousuke Kimoto
Comment 7 2018-02-23 01:53:23 PST
(In reply to Yusuke Suzuki from comment #6) > > Tools/TestWebKitAPI/config.h:64 > > +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT)) > > Why doesn't `PLATFORM(WIN_CAIRO)` work? "PLATFORM(WIN_CAIRO)" is used by both WinCairo WebKitLegacy and WebKit but WinCairo WebKit is an optional build mode for now. In addition, the WinCairo's EWS configuration is dedicated for WebKitLegacy. The EWS will fail during building TestWebKitAPI due to including "WebKIt/WebKit2_C.h" which cannot be referred in the configuration. To avoid such failure, "WebKit/WebKit2_C.h" should be included only for WinCairo WebKit. That is why "BUILDING_WIN_CAIRO_WEBKIT" is newly defined. We need the definition until when we establish to build WinCairo WebKit stably.
Yusuke Suzuki
Comment 8 2018-02-23 06:03:30 PST
Comment on attachment 333683 [details] bz182682-2.patch View in context: https://bugs.webkit.org/attachment.cgi?id=333683&action=review >> Tools/TestWebKitAPI/config.h:64 >> +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT)) > > Why doesn't `PLATFORM(WIN_CAIRO)` work? OK, so please note that we will remove `BUILDING_WIN_CAIRO_WEBKIT` once WinCairo WebKit is done (and non optional).
Yousuke Kimoto
Comment 9 2018-02-23 07:19:55 PST
(In reply to Yusuke Suzuki from comment #8) > >> Tools/TestWebKitAPI/config.h:64 > >> +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT)) > > > > Why doesn't `PLATFORM(WIN_CAIRO)` work? > > OK, so please note that we will remove `BUILDING_WIN_CAIRO_WEBKIT` once > WinCairo WebKit is done (and non optional). Sure, we'll do that. Thank you for your review!
WebKit Commit Bot
Comment 10 2018-02-26 11:08:38 PST
Comment on attachment 333683 [details] bz182682-2.patch Clearing flags on attachment: 333683 Committed r229029: <https://trac.webkit.org/changeset/229029>
WebKit Commit Bot
Comment 11 2018-02-26 11:08:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2018-02-26 11:10:03 PST
<rdar://problem/37908607>
Note You need to log in before you can comment on or make changes to this bug.