Bug 184120

Summary: [Win] MSVC can't compile WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKit2Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174003    
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch none

Fujii Hironori
Reported 2018-03-28 17:46:36 PDT
[Win] MSVC can't compile WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent >WebResourceLoadStatisticsStore.cpp >c:\webkit\gb\webkitbuild\debug\derivedsources\forwardingheaders\wtf\ref.h(61): error C2039: 'deref': is not a member of 'WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>' >c:\webkit\gb\source\webkit\uiprocess\webresourceloadstatisticsstore.cpp(830): note: see declaration of 'WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>' >c:\webkit\gb\webkitbuild\debug\derivedsources\forwardingheaders\wtf\ref.h(55): note: while compiling class template member function 'WTF::Ref<WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>,WTF::DumbPtrTraits<T>>::~Ref(void)' > with > [ > T=WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e> > ] >c:\webkit\gb\source\webkit\uiprocess\webresourceloadstatisticsstore.cpp(826): note: see reference to function template instantiation 'WTF::Ref<WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>,WTF::DumbPtrTraits<T>>::~Ref(void)' being compiled > with > [ > T=WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e> > ] >c:\webkit\gb\source\webkit\uiprocess\webresourceloadstatisticsstore.cpp(824): note: see reference to class template instantiation 'WTF::Ref<WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e>,WTF::DumbPtrTraits<T>>' being compiled > with > [ > T=WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent::<lambda_2ce8022c49d1b38b3e0a628b677d335e> > ]
Attachments
WIP patch (801 bytes, patch)
2018-03-28 17:58 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2018-03-28 19:04 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (1.97 KB, patch)
2018-03-29 18:32 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-03-28 17:58:06 PDT
Created attachment 336740 [details] WIP patch
Fujii Hironori
Comment 2 2018-03-28 18:30:09 PDT
I created a reproducer and reported to MS. https://godbolt.org/g/kZq5Fn https://msdn.microsoft.com/library/mt748084.aspx
Fujii Hironori
Comment 3 2018-03-28 19:04:15 PDT
Created attachment 336745 [details] Patch
Alex Christensen
Comment 4 2018-03-29 10:31:18 PDT
Comment on attachment 336745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336745&action=review > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:824 > - grandfatherExistingWebsiteData([protectedThis = makeRef(*this), callback = WTFMove(callback)]() { > + grandfatherExistingWebsiteData([protectedThis = protectedThis.copyRef(), callback = WTFMove(callback)]() { protectedThis = WTFMove(protectedThis) There's no need to unnecessarily increment and decrement the ref count twice in this case.
Fujii Hironori
Comment 5 2018-03-29 18:32:33 PDT
Created attachment 336828 [details] Patch
Fujii Hironori
Comment 6 2018-04-01 18:57:14 PDT
Thank you for the review, Alex. I addressed the review feedback. Could you review again?
WebKit Commit Bot
Comment 7 2018-04-02 10:44:53 PDT
Comment on attachment 336828 [details] Patch Clearing flags on attachment: 336828 Committed r230162: <https://trac.webkit.org/changeset/230162>
WebKit Commit Bot
Comment 8 2018-04-02 10:44:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-04-02 10:45:44 PDT
<rdar://problem/39110400>
Note You need to log in before you can comment on or make changes to this bug.