Bug 184525

Summary: [Win][WebKit] Implement InjectedBundleWin.cpp
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKit Misc.Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174003    
Attachments:
Description Flags
Patch
none
Patch
none
Patch to land none

Fujii Hironori
Reported 2018-04-11 19:40:59 PDT
[Win][WebKit] Implement InjectedBundleWin.cpp
Attachments
Patch (1.90 KB, patch)
2018-04-11 19:53 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2018-04-16 21:01 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch to land (1.93 KB, patch)
2018-04-17 18:40 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-04-11 19:53:14 PDT
Created attachment 337770 [details] Patch
Konstantin Tokarev
Comment 2 2018-04-16 06:38:36 PDT
Comment on attachment 337770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337770&action=review > Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:36 > + HMODULE lib = ::LoadLibrary(m_path.charactersWithNullTermination().data()); LoadLibrary needs wchar_t, not UChar, so you should use WTF::stringToNullTerminatedWChar here
Fujii Hironori
Comment 3 2018-04-16 21:01:20 PDT
Created attachment 338076 [details] Patch Thank you for the review. Addressed the review feedback.
Konstantin Tokarev
Comment 4 2018-04-17 04:14:31 PDT
Comment on attachment 338076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338076&action=review > Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:45 > + (*proc)(toAPI(this), toAPI(initializationUserData)); You can write it simply as proc(toAPI(this), toAPI(initializationUserData));
Fujii Hironori
Comment 5 2018-04-17 18:40:46 PDT
Created attachment 338177 [details] Patch to land Thank you. Addressed the review feedback.
Fujii Hironori
Comment 6 2018-04-18 00:34:07 PDT
Committed r230754: <https://trac.webkit.org/changeset/230754>
Radar WebKit Bug Importer
Comment 7 2018-04-18 00:35:24 PDT
<rdar://problem/39520256>
Note You need to log in before you can comment on or make changes to this bug.