Bug 184695

Summary: getCharNumAtPosition should take DOMPointInit as argument
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184767    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Dirk Schulze
Reported 2018-04-17 08:27:27 PDT
SVG2 currently defines DOMPoint[1] as argument for getCharNumAtPosition. This is going to change to a DOMPointInit[2]. [1] https://www.w3.org/TR/SVG2/text.html#InterfaceSVGTextContentElement [2] https://github.com/w3c/svgwg/pull/414
Attachments
Patch (6.63 KB, patch)
2018-04-17 08:37 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (8.05 KB, patch)
2018-04-17 08:49 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.09 KB, patch)
2018-05-02 14:13 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2018-04-17 08:37:41 PDT
Created attachment 338116 [details] Patch
Dirk Schulze
Comment 2 2018-04-17 08:49:39 PDT
Created attachment 338119 [details] Patch
Dirk Schulze
Comment 3 2018-05-01 11:53:33 PDT
PR for DOMPointInit landed.
Dirk Schulze
Comment 4 2018-05-02 14:13:52 PDT
Created attachment 339337 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-05-02 14:38:58 PDT
Comment on attachment 339337 [details] Patch for landing Clearing flags on attachment: 339337 Committed r231266: <https://trac.webkit.org/changeset/231266>
WebKit Commit Bot
Comment 6 2018-05-02 14:39:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-02 14:39:21 PDT
<rdar://problem/39919509>
Note You need to log in before you can comment on or make changes to this bug.