Bug 184756

Summary: Rename WindowProxyController to WindowProxy
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ews-watchlist, japhet, sam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 184716    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-04-18 14:14:18 PDT
Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation should use WindowProxyController type, which is a bit confusing currently.
Attachments
Patch (59.45 KB, patch)
2018-04-18 16:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (59.69 KB, patch)
2018-04-18 16:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-04-18 16:10:10 PDT
Created attachment 338272 [details] Patch
Chris Dumez
Comment 2 2018-04-18 16:25:43 PDT
Created attachment 338275 [details] Patch
Sam Weinig
Comment 3 2018-04-18 20:28:26 PDT
Comment on attachment 338275 [details] Patch I think its a bit odd that the class is called WindowProxy and its wrapper is JSDOMWindowProxy, but I think maybe we should address that by renaming JSDOMWindowProxy at some point. r=me.
Chris Dumez
Comment 4 2018-04-18 20:35:20 PDT
(In reply to Sam Weinig from comment #3) > Comment on attachment 338275 [details] > Patch > > I think its a bit odd that the class is called WindowProxy and its wrapper > is JSDOMWindowProxy, but I think maybe we should address that by renaming > JSDOMWindowProxy at some point. r=me. Agreed, I’d like to rename it to JSWindowProxy.
WebKit Commit Bot
Comment 5 2018-04-18 21:02:36 PDT
Comment on attachment 338275 [details] Patch Clearing flags on attachment: 338275 Committed r230794: <https://trac.webkit.org/changeset/230794>
WebKit Commit Bot
Comment 6 2018-04-18 21:02:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-04-18 21:53:33 PDT
<rdar://problem/39553714>
Yusuke Suzuki
Comment 8 2018-04-19 05:47:38 PDT
Committed r230799: <https://trac.webkit.org/changeset/230799>
Note You need to log in before you can comment on or make changes to this bug.