Bug 185537

Summary: REGRESSION(r231057): Encrypted media content playback failures
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jiewen_tan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 184428    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Brent Fulgham
Reported 2018-05-10 17:26:30 PDT
Certain encrypted media content won't stream properly in WebKit if the WebContent process cannot validate the signature of its codec. We removed a bunch of unneeded permissions in Bug 184428, but should hav let the SecurityServer connection available.
Attachments
Patch (1.49 KB, patch)
2018-05-10 17:31 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2018-05-10 21:39 PDT, Brent Fulgham 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-05-10 17:26:51 PDT
<rdar://problem/40038478>
Brent Fulgham
Comment 2 2018-05-10 17:31:28 PDT
Created attachment 340152 [details] Patch
Jiewen Tan
Comment 3 2018-05-10 19:11:34 PDT
Comment on attachment 340152 [details] Patch Thanks Brent for covering this regression. It looks like the block you are trying to add securityd to is restricted with: !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 Should we add it to another block? Or to let it has its own block like?
Brent Fulgham
Comment 4 2018-05-10 19:34:16 PDT
(In reply to Jiewen Tan from comment #3) > Comment on attachment 340152 [details] > Patch > > Thanks Brent for covering this regression. It looks like the block you are > trying to add securityd to is restricted with: > !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 > > Should we add it to another block? Or to let it has its own block like? Oh, that’s probably a good idea, since we removed it for all macOS releases. I’ll revise the patch.
Brent Fulgham
Comment 5 2018-05-10 21:39:27 PDT
Created attachment 340168 [details] Patch
Brent Fulgham
Comment 6 2018-05-11 09:01:35 PDT
Committed r231702: <https://trac.webkit.org/changeset/231702>
Note You need to log in before you can comment on or make changes to this bug.