Bug 187387

Summary:

REGRESSION (r233547): media/media-fullscreen-* LayoutTests are flaky timeouts on macOS WK1

Product:

WebKit

Reporter:

Truitt Savell <tsavell>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

commit-queue, lforschler, realdawei, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Archive of layout-test-results from webkit-cq-03	none
Archive of layout-test-results from webkit-cq-03	none
Archive of layout-test-results from webkit-cq-01	none
Archive of layout-test-results from webkit-cq-03	none
Archive of layout-test-results from webkit-cq-02	none
Archive of layout-test-results from webkit-cq-03	none
Archive of layout-test-results from webkit-cq-03	none
Archive of layout-test-results from webkit-cq-01	none

Truitt Savell

Reported 2018-07-06 09:08:46 PDT

The following layout test is flaky on Sierra and High Sierra WK1 media/media-fullscreen-loop-inline.html media/media-fullscreen-return-to-inline.html Probable cause: I do not know Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmedia-fullscreen-loop-inline.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmedia-fullscreen-return-to-inline.html Both tests became flakey around r233548 though Im not sure that is the revision that caused it. Investigating further.

Attachments
Archive of layout-test-results from webkit-cq-03 (2.29 MB, application/zip) 2018-07-06 13:09 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-cq-03 (2.29 MB, application/zip) 2018-07-06 16:47 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-cq-01 (2.36 MB, application/zip) 2018-07-06 20:42 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-cq-03 (2.30 MB, application/zip) 2018-07-08 22:28 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-cq-02 (2.29 MB, application/zip) 2018-07-08 22:49 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-cq-03 (2.30 MB, application/zip) 2018-07-09 12:23 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-cq-03 (2.30 MB, application/zip) 2018-07-09 12:23 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-cq-01 (2.29 MB, application/zip) 2018-07-09 16:14 PDT, WebKit Commit Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Ryan Haddad

Comment 1 2018-07-06 11:40:55 PDT

*** Bug 187398 has been marked as a duplicate of this bug. ***

Ryan Haddad

Comment 2 2018-07-06 11:41:16 PDT

(In reply to Ryan Haddad from comment #1) > *** Bug 187398 has been marked as a duplicate of this bug. *** This is affecting EWS / commit-queue, so we should get this figured out ASAP.

Truitt Savell

Comment 3 2018-07-06 12:44:21 PDT

found an additional failing test from the same category: media/media-fullscreen-pause-inline.html test history https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmedia-fullscreen-pause-inline.html

WebKit Commit Bot

Comment 4 2018-07-06 13:09:39 PDT

The commit-queue just saw media/media-fullscreen-return-to-inline.html flake (test timed out) while processing attachment 344440 [details] on bug 187396. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 5 2018-07-06 13:09:40 PDT

Created attachment 344447 [details] Archive of layout-test-results from webkit-cq-03

WebKit Commit Bot

Comment 6 2018-07-06 16:47:31 PDT

The commit-queue just saw media/media-fullscreen-return-to-inline.html flake (test timed out) while processing attachment 344473 [details] on bug 186093. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 7 2018-07-06 16:47:32 PDT

Created attachment 344486 [details] Archive of layout-test-results from webkit-cq-03

WebKit Commit Bot

Comment 8 2018-07-06 20:42:20 PDT

The commit-queue just saw media/media-fullscreen-return-to-inline.html flake (test timed out) while processing attachment 344495 [details] on bug 187425. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 9 2018-07-06 20:42:21 PDT

Created attachment 344506 [details] Archive of layout-test-results from webkit-cq-01

WebKit Commit Bot

Comment 10 2018-07-08 22:28:42 PDT

The commit-queue just saw media/media-fullscreen-return-to-inline.html flake (test timed out) while processing attachment 344556 [details] on bug 187457. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 11 2018-07-08 22:28:43 PDT

Created attachment 344562 [details] Archive of layout-test-results from webkit-cq-03

WebKit Commit Bot

Comment 12 2018-07-08 22:49:38 PDT

The commit-queue just saw media/media-fullscreen-return-to-inline.html flake (test timed out) while processing attachment 344557 [details] on bug 187458. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 13 2018-07-08 22:49:39 PDT

Created attachment 344563 [details] Archive of layout-test-results from webkit-cq-02

Ryan Haddad

Comment 14 2018-07-09 10:23:53 PDT

I was able to reproduce timeouts with the following: run-webkit-tests -1 media/media-fullscreen-pause-inline.html media/media-fullscreen-loop-inline.html media/media-fullscreen-return-to-inline.html --iter 50

Ryan Haddad

Comment 15 2018-07-09 10:41:18 PDT

I cannot repro with r233546 locally, so between r233547 and 233548, r233547 seems more likely.

Ryan Haddad

Comment 16 2018-07-09 10:44:56 PDT

*** Bug 187424 has been marked as a duplicate of this bug. ***

Ryan Haddad

Comment 17 2018-07-09 10:45:02 PDT

*** Bug 187406 has been marked as a duplicate of this bug. ***

WebKit Commit Bot

Comment 18 2018-07-09 12:23:23 PDT

The commit-queue just saw media/media-fullscreen-pause-inline.html flake (test timed out) while processing attachment 344599 [details] on bug 187419. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 19 2018-07-09 12:23:24 PDT

Created attachment 344602 [details] Archive of layout-test-results from webkit-cq-03

WebKit Commit Bot

Comment 20 2018-07-09 12:23:34 PDT

The commit-queue just saw media/media-fullscreen-return-to-inline.html flake (test timed out) while processing attachment 344599 [details] on bug 187419. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 21 2018-07-09 12:23:35 PDT

Created attachment 344603 [details] Archive of layout-test-results from webkit-cq-03

WebKit Commit Bot

Comment 22 2018-07-09 16:14:57 PDT

The commit-queue just saw media/media-fullscreen-return-to-inline.html flake (test timed out) while processing attachment 344626 [details] on bug 187425. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 23 2018-07-09 16:14:58 PDT

Created attachment 344634 [details] Archive of layout-test-results from webkit-cq-01

Ryan Haddad

Comment 24 2018-07-09 16:34:12 PDT

I built https://trac.webkit.org/changeset/233547/webkit locally (with the build fix from https://trac.webkit.org/changeset/233550/webkit) and I can reproduce the timeouts using the same command I posted above.

Ryan Haddad

Comment 25 2018-07-10 09:08:17 PDT

The flakiness has stopped, so the rollout worked. *** This bug has been marked as a duplicate of bug 187160 ***

Note You need to log in before you can comment on or make changes to this bug.