Bug 188959

Summary: Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 174968    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2018-08-26 20:39:16 PDT
STEPS TO REPRODUCE: 1. Open WebInspector to a page with a 2D canvas 2. Take a recording of the 2D canvas (try to find one with a few thousand actions) 3. Filter by "as" among the recording actions in the NavigationSidebar 4. Backspace the text in the filter box to just have "a" => Nothing appears, including no "No Filter Results"
Attachments
Patch (1.68 KB, patch)
2018-08-26 20:41 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2018-08-27 09:29 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-08-26 20:41:58 PDT
Created attachment 348115 [details] Patch
Blaze Burg
Comment 2 2018-08-27 09:24:58 PDT
Comment on attachment 348115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348115&action=review r=me but please make it more readable > Source/WebInspectorUI/UserInterface/Views/TreeElement.js:169 > + this.treeOutline.soon.updateVirtualizedElements(!this._hidden && this.selected ? this : null); Pls extract this condition out so I know what the logic is trying to compute. i.e., let focusedTreeElement = ...
Devin Rousso
Comment 3 2018-08-27 09:29:21 PDT
Created attachment 348151 [details] Patch
WebKit Commit Bot
Comment 4 2018-08-27 09:59:48 PDT
Comment on attachment 348151 [details] Patch Clearing flags on attachment: 348151 Committed r235377: <https://trac.webkit.org/changeset/235377>
WebKit Commit Bot
Comment 5 2018-08-27 09:59:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-27 10:00:24 PDT
<rdar://problem/43757744>
Note You need to log in before you can comment on or make changes to this bug.