Bug 189018

Summary: ActiveDOMObjects should be GC collectable as soon as their document is being stopped
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: NEW    
Severity: Normal CC: achristensen, cdumez, ews-watchlist, ggaren, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=189016
https://bugs.webkit.org/show_bug.cgi?id=188728
https://bugs.webkit.org/show_bug.cgi?id=189021
Attachments:
Description Flags
WIP
none
Archive of layout-test-results from ews114 for mac-sierra
none
Archive of layout-test-results from ews202 for win-future
none
Patch
none
Archive of layout-test-results from ews203 for win-future
none
Archive of layout-test-results from ews200 for win-future none

youenn fablet
Reported 2018-08-27 15:33:19 PDT
This applies currently to WebKitMediaSession, IDBDatabase, IDBRequest, MediaDevices and ActiveDOMObjects using setPendingActivity/unsetPendingActivity.
Attachments
WIP (16.40 KB, patch)
2018-08-27 15:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-sierra (2.99 MB, application/zip)
2018-08-27 17:30 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews202 for win-future (12.81 MB, application/zip)
2018-08-27 18:37 PDT, EWS Watchlist 		no flags
Details
Patch (7.89 KB, patch)
2018-09-05 10:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews203 for win-future (12.75 MB, application/zip)
2018-09-05 13:40 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews200 for win-future (12.94 MB, application/zip)
2018-09-05 14:37 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-08-27 15:36:30 PDT
Created attachment 348217 [details] WIP
EWS Watchlist
Comment 2 2018-08-27 15:43:33 PDT
Comment on attachment 348217 [details] WIP Attachment 348217 [details] did not pass bindings-ews (mac): Output: https://webkit-queues.webkit.org/results/9001574 New failing tests: (JS) JSTestInterface.cpp (JS) JSTestNamedConstructor.cpp
EWS Watchlist
Comment 3 2018-08-27 17:30:52 PDT
Comment on attachment 348217 [details] WIP Attachment 348217 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9002727 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2018-08-27 17:30:54 PDT
Created attachment 348243 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 5 2018-08-27 18:37:09 PDT
Comment on attachment 348217 [details] WIP Attachment 348217 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9003673 New failing tests: http/tests/navigation/page-cache-xhr.html http/tests/xmlhttprequest/xhr-response-constructor-subframe.html
EWS Watchlist
Comment 6 2018-08-27 18:37:20 PDT
Created attachment 348249 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Geoffrey Garen
Comment 7 2018-08-28 10:09:09 PDT
Comment on attachment 348217 [details] WIP What happens in the back-forward cache? Is the document considered stopped in that case? If so, how do you avoid GC?
Chris Dumez
Comment 8 2018-08-28 10:33:43 PDT
(In reply to Geoffrey Garen from comment #7) > Comment on attachment 348217 [details] > WIP > > What happens in the back-forward cache? Is the document considered stopped > in that case? If so, how do you avoid GC? No, state is suspended while in page cache, not stopped.
Chris Dumez
Comment 9 2018-08-28 10:35:08 PDT
(In reply to Chris Dumez from comment #8) > (In reply to Geoffrey Garen from comment #7) > > Comment on attachment 348217 [details] > > WIP > > > > What happens in the back-forward cache? Is the document considered stopped > > in that case? If so, how do you avoid GC? > > No, state is suspended while in page cache, not stopped. As in we call suspend() on the active dom objects before entering page cache, never stop(). Stop() is only called when the script execution context is about to be destroyed.
Chris Dumez
Comment 10 2018-08-28 10:46:13 PDT
Comment on attachment 348217 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=348217&action=review > Source/WebCore/dom/ScriptExecutionContext.h:133 > + virtual bool isStopped() = 0; There is already ScriptExecutionContext::activeDOMObjectsAreStopped()
youenn fablet
Comment 11 2018-09-05 10:37:25 PDT
Created attachment 348937 [details] Patch
EWS Watchlist
Comment 12 2018-09-05 13:40:22 PDT
Comment on attachment 348937 [details] Patch Attachment 348937 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9104756 New failing tests: http/tests/navigation/page-cache-xhr.html http/tests/xmlhttprequest/xhr-response-constructor-subframe.html
EWS Watchlist
Comment 13 2018-09-05 13:40:36 PDT
Created attachment 348960 [details] Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
EWS Watchlist
Comment 14 2018-09-05 14:37:19 PDT
Comment on attachment 348937 [details] Patch Attachment 348937 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9105570 New failing tests: http/tests/navigation/page-cache-xhr.html http/tests/xmlhttprequest/xhr-response-constructor-subframe.html
EWS Watchlist
Comment 15 2018-09-05 14:37:31 PDT
Created attachment 348963 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Alex Christensen
Comment 16 2021-11-01 12:52:38 PDT
Comment on attachment 348937 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Note You need to log in before you can comment on or make changes to this bug.