Bug 189764

Summary: Import WPT tests for css custom properties api
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189692    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews117 for mac-sierra
none
Patch none

Attachments
Patch (136.52 KB, patch)
2018-09-21 19:46 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.44 MB, application/zip)
2018-09-21 20:50 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews117 for mac-sierra (3.15 MB, application/zip)
2018-09-21 21:46 PDT, EWS Watchlist 		no flags
Details
Patch (137.77 KB, patch)
2018-09-24 14:20 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2018-09-21 19:46:38 PDT
Created attachment 350478 [details] Patch
EWS Watchlist
Comment 2 2018-09-21 20:50:54 PDT
Comment on attachment 350478 [details] Patch Attachment 350478 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9307265 New failing tests: imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-initial.html imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles.html imported/w3c/web-platform-tests/css/css-properties-values-api/property-cascade.html imported/w3c/web-platform-tests/css/css-properties-values-api/typedom.tentative.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-properties-inheritance.html imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html imported/w3c/web-platform-tests/css/css-properties-values-api/url-resolution.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-computation.html imported/w3c/web-platform-tests/css/css-properties-values-api/register-property.html imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom.html
EWS Watchlist
Comment 3 2018-09-21 20:50:56 PDT
Created attachment 350485 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 4 2018-09-21 21:46:00 PDT
Comment on attachment 350478 [details] Patch Attachment 350478 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9307378 New failing tests: imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-initial.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-properties-inheritance.html imported/w3c/web-platform-tests/css/css-properties-values-api/property-cascade.html imported/w3c/web-platform-tests/css/css-properties-values-api/typedom.tentative.html imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles.html imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html imported/w3c/web-platform-tests/css/css-properties-values-api/url-resolution.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-computation.html imported/w3c/web-platform-tests/css/css-properties-values-api/register-property.html imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom.html
EWS Watchlist
Comment 5 2018-09-21 21:46:01 PDT
Created attachment 350495 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Justin Michaud
Comment 6 2018-09-24 14:20:11 PDT
Created attachment 350685 [details] Patch
Ryosuke Niwa
Comment 7 2018-09-24 15:28:28 PDT
Comment on attachment 350685 [details] Patch Is this feature somehow enabled in WebKitTestRunner by default?
Justin Michaud
Comment 8 2018-09-24 16:28:11 PDT
Yes. Dean confirmed that for web platform tests, experimental features are enabled by default. We still need the header comment for regular tests though, as far as I know. Also, it doesn't work for webkit 1, which is why I changed the test expectation.
Ryosuke Niwa
Comment 9 2018-09-24 16:37:40 PDT
Comment on attachment 350685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350685&action=review r=me > LayoutTests/platform/mac-wk1/TestExpectations:625 > +imported/w3c/web-platform-tests/css/css-properties-values-api/ [ Skip ] > css-custom-properties-api [ Skip ] Why is this feature not supported on WK1? That seems like a weird discrepancy. We certainly shouldn't ship this feature only to WK2.
Justin Michaud
Comment 10 2018-09-24 16:46:06 PDT
It should work in WK1, but the feature flag is not supported because it required a bunch of manual changes to get it to work with the test runner. It didn't seem like it was worth the effort when I was talking with Dean and Simon, at least for now.
WebKit Commit Bot
Comment 11 2018-09-24 17:05:40 PDT
Comment on attachment 350685 [details] Patch Clearing flags on attachment: 350685 Committed r236444: <https://trac.webkit.org/changeset/236444>
WebKit Commit Bot
Comment 12 2018-09-24 17:05:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-09-24 17:06:21 PDT
<rdar://problem/44746424>
Note You need to log in before you can comment on or make changes to this bug.