Bug 190403

Summary: Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, justin_fan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190305, 190325    
Bug Blocks:    
Attachments:
Description Flags
Patch
joepeck: review+
Patch none

Devin Rousso
Reported 2018-10-09 10:30:08 PDT
Related bugs: - <https://webkit.org/b/190305> - <https://webkit.org/b/190325>
Attachments
Patch (5.89 KB, patch)
2018-10-09 10:34 PDT, Devin Rousso 		joepeck: review+
DetailsFormatted DiffDiff
Patch (5.89 KB, patch)
2018-10-09 10:44 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-09 10:34:05 PDT
Created attachment 351888 [details] Patch
Joseph Pecoraro
Comment 2 2018-10-09 10:40:04 PDT
Comment on attachment 351888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review r=me > LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78 > + // This can't use `awaitEvent` since the promise resolution happens on the next tick.sss Whats up with the "tick.sss" at the end of this sentence? Just a typo?
Devin Rousso
Comment 3 2018-10-09 10:43:28 PDT
Comment on attachment 351888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review >> LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78 >> + // This can't use `awaitEvent` since the promise resolution happens on the next tick.sss > > Whats up with the "tick.sss" at the end of this sentence? Just a typo? That was my attempt at Cmd+S on the bus 😅
Devin Rousso
Comment 4 2018-10-09 10:44:01 PDT
Created attachment 351893 [details] Patch
WebKit Commit Bot
Comment 5 2018-10-09 12:04:25 PDT
Comment on attachment 351893 [details] Patch Clearing flags on attachment: 351893 Committed r236972: <https://trac.webkit.org/changeset/236972>
WebKit Commit Bot
Comment 6 2018-10-09 12:04:27 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-10-09 12:07:35 PDT
<rdar://problem/45134558>
Note You need to log in before you can comment on or make changes to this bug.