Bug 190987

Summary:

Web Inspector: provide options to WI.cssPath for more verbosity

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

190754

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Devin Rousso

Reported 2018-10-27 10:59:59 PDT

This will let us be more verbose in logging.

Attachments
Patch (16.31 KB, patch) 2018-10-27 11:03 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (16.35 KB, patch) 2018-10-27 11:10 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (18.29 KB, patch) 2018-10-29 19:29 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (18.65 KB, patch) 2018-10-30 14:33 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2018-10-27 11:03:26 PDT

Created attachment 353237 [details] Patch

EWS Watchlist

Comment 2 2018-10-27 11:06:09 PDT Comment hidden (obsolete)

Attachment 353237 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Devin Rousso

Comment 3 2018-10-27 11:10:19 PDT

Created attachment 353241 [details] Patch Whoops. Forgot bug number.

Devin Rousso

Comment 4 2018-10-29 19:29:17 PDT

Created attachment 353345 [details] Patch

Blaze Burg

Comment 5 2018-10-30 12:48:17 PDT

Comment on attachment 353345 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353345&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + * UserInterface/Base/DOMUtilities.js: You need to describe the enhancements being made here. > Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js:138 > + let unique = new Map; Nit: uniqueAttributes > LayoutTests/inspector/dom/domutilities-csspath.html:10 > + async function nodeForSelector(selector) { v.nice!

Devin Rousso

Comment 6 2018-10-30 14:33:33 PDT

Created attachment 353409 [details] Patch

WebKit Commit Bot

Comment 7 2018-10-30 16:06:33 PDT

Comment on attachment 353409 [details] Patch Clearing flags on attachment: 353409 Committed r237608: <https://trac.webkit.org/changeset/237608>

WebKit Commit Bot

Comment 8 2018-10-30 16:06:34 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-10-30 16:07:27 PDT

<rdar://problem/45684504>

Note You need to log in before you can comment on or make changes to this bug.