Bug 191242

Summary: Parsing support for text-underline-offset and text-decoration-thickness
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, dino, jonlee, lamarque, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 190774, 216092    
Attachments:
Description Flags
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2018-11-04 20:55:01 PST
Parsing support for text-underline-offset and text-decoration-thickness
Attachments
Patch (57.11 KB, patch)
2018-11-04 20:59 PST, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-11-04 20:59:33 PST
Created attachment 353826 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-11-05 11:15:14 PST
Comment on attachment 353826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review > Source/WebCore/rendering/style/StyleRareInheritedData.h:85 > + TextUnderlineOffset textUnderlineOffset; Why not put into the bitfield? > Source/WebCore/rendering/style/TextDecorationThickness.h:109 > + Type m_type; > + float m_length; 3 bytes of padding here, sadly, and the float is wasted for the "from font" case.
Wenson Hsieh
Comment 3 2018-11-05 12:09:33 PST
Comment on attachment 353826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review > Source/WebCore/ChangeLog:18 > + We still don't suppor the left and right values on text-underline-position. We should add those eventually. Nit - support
Myles C. Maxfield
Comment 4 2018-11-05 15:37:49 PST
Comment on attachment 353826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review >> Source/WebCore/rendering/style/StyleRareInheritedData.h:85 >> + TextUnderlineOffset textUnderlineOffset; > > Why not put into the bitfield? I don't understand this comment. >> Source/WebCore/rendering/style/TextDecorationThickness.h:109 >> + float m_length; > > 3 bytes of padding here, sadly, and the float is wasted for the "from font" case. Yeah :( Do you have any ideas about how to improve it?
Myles C. Maxfield
Comment 5 2018-11-05 16:07:01 PST
Comment on attachment 353826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review >>> Source/WebCore/rendering/style/StyleRareInheritedData.h:85 >>> + TextUnderlineOffset textUnderlineOffset; >> >> Why not put into the bitfield? > > I don't understand this comment. Oh, it's because TextUnderlineOffset can be auto or a length. text-underline-offset is different from text-underline-position :(
Myles C. Maxfield
Comment 6 2018-11-05 16:11:24 PST
Committed r237835: <https://trac.webkit.org/changeset/237835>
Radar WebKit Bug Importer
Comment 7 2018-11-05 16:12:19 PST
<rdar://problem/45824920>
Myles C. Maxfield
Comment 8 2018-11-05 20:30:54 PST
Committed r237843: <https://trac.webkit.org/changeset/237843>
Brent Fulgham
Comment 9 2022-07-13 11:45:59 PDT
*** Bug 101931 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.