Bug 191526

Summary: [WebAuthN] Store necessary authenticator info into HID authenticators
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alex.gaynor, bfulgham, cdumez, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch none

Jiewen Tan
Reported 2018-11-11 18:06:58 PST
Store necessary authenticator info into HID authenticators.
Attachments
Patch (2.49 KB, patch)
2018-11-14 01:55 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2018-11-14 01:55:11 PST
Created attachment 354784 [details] Patch
Jiewen Tan
Comment 2 2018-11-15 12:03:24 PST
Comment on attachment 354784 [details] Patch I guess I don't need any review for this one. I will land an unreviewed patch on my own.
Chris Dumez
Comment 3 2018-11-15 12:06:40 PST
Comment on attachment 354784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354784&action=review > Source/WebKit/ChangeLog:8 > + Somehow this is fixed by r238166. Some very minor improvment over it. typo: improvment "Somehow"? You don't know how? I personally find this changelog confusing.
Jiewen Tan
Comment 4 2018-11-15 13:11:26 PST
(In reply to Chris Dumez from comment #3) > Comment on attachment 354784 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354784&action=review > > > Source/WebKit/ChangeLog:8 > > + Somehow this is fixed by r238166. Some very minor improvment over it. > > typo: improvment > > "Somehow"? You don't know how? I personally find this changelog confusing. I thought I was working on a branch for this change, and I didn't. Therefore I actually made this change in: Committed r238166: <https://trac.webkit.org/changeset/238166>. The change is actually simple as well. Which I just move the AuthenticatorGetInfoResponse to the CtapHidAuthenticator after we have the response. And use the userVerificationAvailability info when issuing requests to authenticators in CtapHidAuthenticator.
Jiewen Tan
Comment 5 2018-11-15 13:32:57 PST
Committed r238247: <https://trac.webkit.org/changeset/238247>
Radar WebKit Bug Importer
Comment 6 2018-11-15 13:33:30 PST
<rdar://problem/46106274>
Alex Christensen
Comment 7 2021-11-01 12:46:16 PDT
Comment on attachment 354784 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Note You need to log in before you can comment on or make changes to this bug.