Bug 191558

Summary: [IntersectionObserver] Support having targets in multiple windows
Product: WebKit Reporter: Ali Juma <ajuma>
Component: Layout and RenderingAssignee: Ali Juma <ajuma>
Status: ASSIGNED    
Severity: Normal CC: achristensen, ahmad.saleem792, ap, bfulgham, cdumez, cmarcelo, dbates, esprehn+autocc, ews-watchlist, fred.wang, kangil.han, kondapallykalyan, rniwa, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206556
Bug Depends on:    
Bug Blocks: 159475    
Attachments:
Description Flags
Patch
none
Patch none

Ali Juma
Reported 2018-11-12 12:56:32 PST
An implicit-root IntersectionObserver should be able to have targets in multiple windows, and observe the intersection of each of them with their window's viewport.
Attachments
Patch (18.45 KB, patch)
2018-11-12 13:07 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
Patch (18.42 KB, patch)
2018-11-12 13:11 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-11-12 13:07:46 PST
Created attachment 354579 [details] Patch
EWS Watchlist
Comment 2 2018-11-12 13:09:26 PST
Attachment 354579 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ali Juma
Comment 3 2018-11-12 13:11:01 PST
Created attachment 354580 [details] Patch
Simon Fraser (smfr)
Comment 4 2018-11-12 13:33:48 PST
Comment on attachment 354579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354579&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Fix this.
Ali Juma
Comment 5 2018-11-12 13:39:15 PST
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 354579 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354579&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > Fix this. Removed that line in the latest patch since there's a web platform test that covers this (and passes after this patch). Is that sufficient test coverage or do you think we need more?
Frédéric Wang (:fredw)
Comment 6 2020-02-21 03:28:51 PST
@Ali: What's the status of this? Are you still working on this patch?
Ali Juma
Comment 7 2020-02-21 05:58:20 PST
(In reply to Frédéric Wang (:fredw) from comment #6) > @Ali: What's the status of this? Are you still working on this patch? This got dropped in the lead-up to IntersectionObserver being enabled by default, since it seemed like a risky change relative to the edge-case that it handles. The patch should mostly still apply, I expect.
Alex Christensen
Comment 8 2021-11-01 12:46:53 PDT
Comment on attachment 354580 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Note You need to log in before you can comment on or make changes to this bug.