Bug 191758

Summary: Web Inspector: Audit: add default tests
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190754    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2018-11-16 10:34:45 PST
We should create some default tests so that the initial Audit tab isn't empty.
Attachments
Patch (17.17 KB, patch)
2018-11-16 10:37 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (23.34 KB, patch)
2018-11-16 17:12 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (23.24 KB, patch)
2018-11-16 17:19 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-11-16 10:37:15 PST
Created attachment 355075 [details] Patch I'd like to add another default test, so this is not committable yet. It is reviewable tho :)
Matt Baker
Comment 2 2018-11-16 13:11:08 PST
Comment on attachment 355075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355075&action=review r=me > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:85 > +localizedStrings["Add default audits"] = "Add default audits"; Push button text should use title case: "Add Default Audits".
Matt Baker
Comment 3 2018-11-16 13:11:38 PST
Since this just adds the accessibility audit, the name of the bug should probably be retitled.
Devin Rousso
Comment 4 2018-11-16 13:15:03 PST
(In reply to Matt Baker from comment #3) > Since this just adds the accessibility audit, the name of the bug should > probably be retitled. I’m planning on adding another audit later today (reuploading a new patch).
Devin Rousso
Comment 5 2018-11-16 17:12:05 PST
Created attachment 355165 [details] Patch Any feedback on the default audits I've written would be greatly appreciated :)
Devin Rousso
Comment 6 2018-11-16 17:19:39 PST
Created attachment 355167 [details] Patch Use template strings for audit test names and functions
WebKit Commit Bot
Comment 7 2018-11-16 18:14:53 PST
Comment on attachment 355167 [details] Patch Clearing flags on attachment: 355167 Committed r238334: <https://trac.webkit.org/changeset/238334>
WebKit Commit Bot
Comment 8 2018-11-16 18:14:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-11-16 18:15:27 PST
<rdar://problem/46145781>
Note You need to log in before you can comment on or make changes to this bug.